The forum operates in read-only mode. Please head to StackOverflow for support.

Mon, 07/13/2009 - 08:28

stylo~

Joined: 13/07/2009

Posts: 40

ckeditor 3 ruins block tag display, adds breaks and tabs

Surely it won't be released like this, will it?

<p>some text</p><p>more text.</p>

<p><br>   some text</p><br><p><br>   more text.</p>

http://www.fckeditor.net/nightly/fckedi ... fault.html
http://ckeditor.com/ckeditor/3.0rc/_sam ... class.html

Tue, 07/14/2009 - 10:40

stylo~

Joined: 13/07/2009

Posts: 40

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

Anyone?

Wed, 07/15/2009 - 02:53

ries

Joined: 15/07/2009

Posts: 1

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

I've hated that already in the fckeditor, so I am happy with the config ability I noticed:

I have set the following setting in the /_source/core/config.js:

   enterMode : CKEDITOR.ENTER_BR

If you work with your own (filled) /config.js (like I do), then set it like this:

CKEDITOR.editorConfig = function( config )
{
    config.enterMode = 2;
};

This way I have no longer the spontaneous paragraph tag (<p></p>) anymore and the source it makes is better.
I'm testing CK V3 just shortly, so I don't know if CK V3 is messing up other tags as well. Just noticed this one quite rapidly.

Cheers,

Ries

Wed, 07/15/2009 - 13:17

stylo~

Joined: 13/07/2009

Posts: 40

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

I don't think that is the same issue. I have a P tag (or whatever other block tag) already; it is the additional added junk inside them is ruining the saved text.

How to stop it?

You'd think this would be a very common complaint on a RC. It's completely unusable as-is.

Fri, 07/17/2009 - 07:23

stylo~

Joined: 13/07/2009

Posts: 40

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

Anyone?

Sun, 08/02/2009 - 08:18

stylo~

Joined: 13/07/2009

Posts: 40

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

Does anyone know how to fix this so it can be used?

Tue, 08/25/2009 - 12:16

wiktor

Joined: 16/07/2007

Posts: 1641

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

CKEDITOR.replace( 'editor1',
   {
      on :
      {
         instanceReady : function( ev )
         {
            this.dataProcessor.writer.setRules( 'p',
               {
                  indent : false,
                  breakBeforeOpen : true,
                  breakAfterOpen : false,
                  breakBeforeClose : false,
                  breakAfterClose : true
               });
         }
      }
   });

CKEDITOR.on( 'instanceReady', function( ev )
   {
      ev.editor.dataProcessor.writer.setRules( 'p',
         {
            indent : false,
            breakBeforeOpen : true,
            breakAfterOpen : false,
            breakBeforeClose : false,
            breakAfterClose : true
         });
   });

Output Formatting

Wiktor Walc
CTO, CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+

Fri, 08/28/2009 - 08:07

stylo~

Joined: 13/07/2009

Posts: 40

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

Thanks!

Why isn't the formatting done correctly in the first place, between block tags, not within tags? Within tags makes no sense at all.

What is the syntax to make it apply to all block tags?

Is there some change we can make to get it to indent between all block tags instead?

Thanks again! Other than this problem, v3 seems great.

Edit: for anyone wanting to prevent all breaks after the start of a tag, just search ckeditor.js and change breakAfterOpen to false. In my brief tests it seems to fix it. If there is a an easy one-liner to set this for all tags without touching core files, please add a comment.

Tue, 09/15/2009 - 13:08

soninke

Joined: 15/09/2009

Posts: 1

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

CKEDITOR.on('instanceReady', function(ev)
    {
        var tags = ['p', 'ol', 'ul', 'li']; // etc.

        for (var key in tags) {
            ev.editor.dataProcessor.writer.setRules(tags[key],
                {
                    indent : false,
                    breakBeforeOpen : true,
                    breakAfterOpen : false,
                    breakBeforeClose : false,
                    breakAfterClose : true
                });
        }
    });

Fri, 08/27/2010 - 17:37

#10

2ears

Joined: 27/08/2010

Posts: 1

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

Sorry to re-open this topic a bit late.

I just switched from 2.x to 3.x and this "feature" is really breaking everything.
Beside that, I cannot see the rational behind adding, by default, a breakline and a indent after each opening tag.
And pragmatically, do a Google search and you will find that everybody is complaining about that behaviour.

The solution offered (writer.setRules( 'p', 'h1', 'h2', etc.)) is really not up to the problem.

What we need is a way to change this behaviour for all tags once for all at runtime not touching the config.js file.

Thanks in advance and thanks for all your hard work improving CKeditor.

Sat, 10/23/2010 - 09:58

#11

outsidedesign

Joined: 03/06/2008

Posts: 6

Re: ckeditor 3 ruins block tag display, adds breaks and tabs

Soninke - thank you. I needed to render all the html as a single block with no line breaks to pass into a javascript array to show song notes on a music player I'm working on.

By using your example in my custom config.js I only had to make one change and all instances of CKeditor were affected.

Thanks again for a simple but powerful solution.