Select new style to kill old style

All I've got is 3 headings and "normal" (paragraph) defined in the style. If I place a line of text in one style, then decide I want to change it, is there any way I can tell FCKeditor to cancel the previous style when I change the style box? At the moment, just changing the combo box produces something like:
<p><h1><h2>Some menu</h2></h1></p>, which is not good!

Thu, 12/08/2005 - 14:37

bnoblet

Joined: 29/11/2006

Posts: 179

RE: Select new style to kill old style

I too would like to see this feature, at least as an option. Our users regularly get into nested tag hell and (understandably!) don't realise what they've done.

I'd like to see an option to make the styles dropdown work more like the font-formats dropdown. ie. the selected style always replaces the containing tag.

Fri, 12/16/2005 - 03:35

kskrumpet

Joined: 08/12/2005

Posts: 3

RE: Select new style to kill old style

I've been playing with the source code and have found a rather messy solution, but it'll do for me. The problem is that when you remove a style, it unhighlights the text that you wanted to stylize. Therefore you have to find the text that was highlighted before in order to then apply the next style. An example of doing this is below, but it's not a complete solution - I've eliminated some problems I was having on Netscape by only allowing styling of highlighted text, and haven't even bothered with IE support!

(Note that this is from the uncompressed source and it'll only work on gecko, and I had to retype it into this thread, so I may have made a typo or two - but you get the idea)

FCKStyleCommand.prototype.Execute = function( styleName, styleComboItem )
{
var C=this.GetActiveStyles();
var D = ''+FCK.EditorWindow.getSelection();
if (!D) {
alert("Please select some text to style");
} else {
if (styleComboItem.Selected) {
FCKUndo.SaveUndoStep();
styleComboItem.Style.RemoveFromSelection();
FCKUndo.SaveUndoStep();
FCK.Focus();
FCK.Events.FireEvent("OnSelectionChange");
} else {
FCKUndo.SaveUndoStep();
if (C.length>0){
for (var i=0;i<C.length;i++) {
C[i].RemoveFromSelection();
FCK.EditorWindow.find(D, true, false, false, false, false, false);
};
}
styleComboItem.Style.ApplyToSelection();
FCKUndo.SaveUndoStep();
FCK.Focus();
FCK.Events.FireEvent("OnSelectionChange");
}
}
}

Mon, 04/24/2006 - 11:11

alexzr

Joined: 05/05/2006

Posts: 6

RE: Select new style to kill old style

Based on kskrumpet code i´ve made some changes on fckeditorcode_ie_2.js to work on IE.
FCKStyleCommand.prototype.Execute=function(A,B){
FCKUndo.SaveUndoStep();
var C=this.GetActiveStyles();
var D=FCK.EditorDocument.selection.createRange().text;
if(C.length>0)
C[0].RemoveFromSelection();
B.Style.RemoveFromSelection();
var E = FCK.EditorDocument.body.createTextRange();
if(E.findText(D, 1, 0)){
E.scrollIntoView();
E.select();
E.collapse(false);
};
B.Style.ApplyToSelection();
FCKUndo.SaveUndoStep();
FCK.Focus();
FCK.Events.FireEvent("OnSelectionChange");
};

Mon, 04/24/2006 - 13:47

alexzr

Joined: 05/05/2006

Posts: 6

RE: Select new style to kill old style

this new version works on each line individualy.
this code does not alow one style inside of any other

FCKStyleCommand.prototype.Execute=function(A,B){
FCKUndo.SaveUndoStep();
var C = FCK.EditorDocument.selection.createRange().text;
C = C.replace('\r','');
var D = C.split('\n');
var E,F;
for (var i=0;i<D.length;i++){
E = FCK.EditorDocument.body.createTextRange();
if(E.findText(D[i], 1, 0)){
E.select();
F = this.GetActiveStyles();
if(F.length>0)
F[0].RemoveFromSelection();
};
E = FCK.EditorDocument.body.createTextRange();
if(E.findText(D[i], 1, 0)){
E.select();
B.Style.ApplyToSelection();
};
FCKUndo.SaveUndoStep();
FCK.Focus();
FCK.Events.FireEvent("OnSelectionChange");
};
};