Double quotes in tag attributes error (any help is appreciat

Sat, 10/18/2008 - 23:42

#2

williamk

Joined: 18/10/2008

Posts: 15

Re: Double quotes in tag attributes error (any help is appreciat

That's a good question!

I have been combing this forum for hours trying to find a solution and have tried all sorts of filtering and encoding to get all of the message area saved to database. I can remove the single and double quotes easy enough but when the page is re-edited by FCK it puts the double quotes back again where it thinks they belong (not where we want) and jumbles the code because it insists on adding unwanted tags like alt="" back into the code... the result is a messup.

In fact if the alt="" tag wasn't forced onto every image, I could have gone home a long time ago.

I would also like to see the font sizes in pt as in 8pt, 10pt, etc or even 1,2,3... not big, bigger, bigger again!

Anyways, we have spent the last couple of days integrating FCK into a project that is soon to be released [purchasing a developer licence] but if we can't resolve these issues soon we'll have to find find something more robust.

Is fckconfig.js the only file to edit for this? Is there somewhere else where I can remove ALT tags completely?

Sun, 10/19/2008 - 13:29

#3

egranville

Joined: 12/10/2008

Posts: 6

Re: Double quotes in tag attributes error (any help is appreciat

Hi William!

Great to see I'm not the only one with this problem but strange that we're still the only two. We must be doing something wrong I'd say!

I was working with Innova editor and still use it in my projects. I wanted to try out FCK for the uniform campatibility it has. But haven't got it to work properly yet. I don't understand why they use an input field instead of a text area, which would clear this problem. Or am I seeing/implementing it completely wrong?

Anybody who might help us with this?

Sun, 10/19/2008 - 14:05

#4

williamk

Joined: 18/10/2008

Posts: 15

Re: Double quotes in tag attributes error (any help is appreciat

Further to this...

I resolved the ALT tag issue by adding a value for it. Then when FCK adds the quotes again, the html code is correct.

I did have another issue with an unwanted "> appearing on the preview page but using an invisible textarea to hold the FCK data instead of a hidden text field solved that problem.

Sun, 10/19/2008 - 14:16

#5

williamk

Joined: 18/10/2008

Posts: 15

Re: Double quotes in tag attributes error (any help is appreciat

You can still use a text field in the FCK editor if you do what I did to resolve filtering issues...

Set the FCKeditor page to send to a preview page which in turn then submits to the database. Then you have the freedom to do anything you want with the data before saving.

On the preview page I used a hidden textarea to hold the FCK data while displaying the html separately for a preview.

Sun, 10/19/2008 - 15:33

#6

alfonsoml

Joined: 31/12/2006

Posts: 3737

Re: Double quotes in tag attributes error (any help is appreciat

I guess that you are over-complicating things.

Use any of the server side integration samples, you don't need to care about how the data is available in the page, you just use an object and set the value with the initial HTML that you want and then call the method to generate all the html to really create the FCKeditor instance. The server integration will take care of escaping the data and generating everything correctly.

Just make sure that your page is valid HTML. If you are generating invalid HTML (for example, using the textarea replacement method but not html-escaping the data inside the textarea, or using directly a javascript object but not escaping the string according to javascript syntax rules), then the browser will parse your data incorrectly and there's no magic after that. FCKeditor can read only the data provided by the browser.

Sun, 10/19/2008 - 15:47

#7

williamk

Joined: 18/10/2008

Posts: 15

Re: Double quotes in tag attributes error (any help is appreciat

I'm uploading an image first and then loading it into FCK editor from a selection of templates.

The image shown is only a token for a preview as the actual image shown to the public cannot be displayed in FCK html because it's encrypted.

So yes, it is complicated but no more than needed in this instance.

So far it's looking good :-)

Sun, 10/19/2008 - 16:22

#8

alfonsoml

Joined: 31/12/2006

Posts: 3737

Re: Double quotes in tag attributes error (any help is appreciat

It doesn't matter that the image is restricted or that you are using templates. Using double quotes shouldn't matter to you, the integration of FCKeditor takes care of those details.
An empty alt for an image isn't the best option with regards to accesibility of your site, but it shouldn't create any problem to the processing.

That comment about an "> in the preview area and hiding the data and then resending it again are symptoms that there is some problem in your application, so instead of hiding it, you should stop, take a moment of rest and start from scratch, review the samples and you'll see that integration FCKeditor is very easy, there's no need to do double postings to the server.

Sun, 10/19/2008 - 16:50

#9

williamk

Joined: 18/10/2008

Posts: 15

Re: Double quotes in tag attributes error (any help is appreciat

There is no error in the code, except for my mistake of putting the html output from FCK in a text field on the preview page. Displaying it in a textarea solved the problem.

Mon, 10/20/2008 - 23:10

#10

egranville

Joined: 12/10/2008

Posts: 6

Re: Double quotes in tag attributes error (any help is appreciat

Alfonso,

I totally agree with your point.I'm therefore only trying to get the functionality to work as intendend. Somehow doble quotes are not converted by php? I think.

This is my implementation:

                     
                     //REQUIRE: fck-editor plugin class
                     require_once(FS_PATH_PLUGINS . 'fckeditor/fckeditor_php5.php');
                     
                     // INSTANTIATE: editor object
                     $oFCKeditor = new FCKeditor($id) ;
                     $oFCKeditor->BasePath                   = WS_PATH_PLUGINS  . 'fckeditor/';
                     $oFCKeditor->Width                      = 610;
                     $oFCKeditor->Height                   = 400 ;
                     $oFCKeditor->Config['BaseHref']            = 'http://' . $_SERVER['HTTP_HOST'] . '/';
                     $oFCKeditor->Config['DocType']            = '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">';
                     $oFCKeditor->Config['EditorAreaCSS']      = WS_PATH_CSS . 'editor.style.css';
                     $oFCKeditor->Config['FontSizes']         = '8px;10px;12px;14px;16px;18px;20px;24px;30px;';
                     $oFCKeditor->Config['SkinPath']          = $oFCKeditor->BasePath . 'editor/skins/Office2003/' ;
                     $oFCKeditor->Config['AutoDetectLanguage']   = false ;
                     $oFCKeditor->Config['DefaultLanguage']      = LANGUAGE ;
                     $oFCKeditor->ToolbarSet                  = 'Gcore' ;
                     $oFCKeditor->Value                      = $field['value'];

Am I doing anything wrong? $field['value'] contains just normal HTML, nothing scary.

What functions are being used to convert the special characters? I suspect them to malfunction on my server (Windows/apache2/php5.2.. )

Tue, 10/21/2008 - 11:56

#11

egranville

Joined: 12/10/2008

Posts: 6

Re: Double quotes in tag attributes error (any help is appreciat

I have some more information:

I found this to be very strange...

In the PHP5 file you have this function:

   /**
    * Return the HTML code required to run FCKeditor.
    *
    * @return string
    */
   public function CreateHtml()
   {
      echo $HtmlValue = htmlspecialchars( $this->Value ) ;

      $Html = '' ;

      if ( $this->IsCompatible() )
      {
         if ( isset( $_GET['fcksource'] ) && $_GET['fcksource'] == "true" )
            $File = 'fckeditor.original.html' ;
         else
            $File = 'fckeditor.html' ;

         $Link = "{$this->BasePath}editor/{$File}?InstanceName={$this->InstanceName}" ;

         if ( $this->ToolbarSet != '' )
            $Link .= "&amp;Toolbar={$this->ToolbarSet}" ;

         // Render the linked hidden field.
         $Html .= "<input type=\"hidden\" id=\"{$this->InstanceName}\" name=\"{$this->InstanceName}\" value=\"{$HtmlValue}\" style=\"display:none\" />" ;

         // Render the configurations hidden field.
         $Html .= "<input type=\"hidden\" id=\"{$this->InstanceName}___Config\" value=\"" . $this->GetConfigFieldString() . "\" style=\"display:none\" />" ;

         // Render the editor IFRAME.
         $Html .= "<iframe id=\"{$this->InstanceName}___Frame\" src=\"{$Link}\" width=\"{$this->Width}\" height=\"{$this->Height}\" frameborder=\"0\" scrolling=\"no\"></iframe>" ;
      }
      else
      {
         if ( strpos( $this->Width, '%' ) === false )
            $WidthCSS = $this->Width . 'px' ;
         else
            $WidthCSS = $this->Width ;

         if ( strpos( $this->Height, '%' ) === false )
            $HeightCSS = $this->Height . 'px' ;
         else
            $HeightCSS = $this->Height ;

         $Html .= "<textarea name=\"{$this->InstanceName}\" rows=\"4\" cols=\"40\" style=\"width: {$WidthCSS}; height: {$HeightCSS}\">{$HtmlValue}</textarea>" ;
      }

      return $Html ;
   }

You can see I placed an echo in front of the htmlspecialchars funtion, strangely that produces this output:

&lt;p&gt;gdjasgdjsg &gt; fdefwe&lt; dewdfew&amp; dewdf&quot;ewf&lt;/p&gt;

While in my page source I see this code:

<input type="hidden" id="body" name="body" value="<p>gdjasgdjsg > fdefwe< dewdfew& dewdf"ewf</p>" style="display:none" />

Something wrong right? BTW I haven't changed the PHP5 file, other than the echo function for debugging purposes.

I think we should be close.

Tue, 10/21/2008 - 15:42

#12

egranville

Joined: 12/10/2008

Posts: 6

Re: Double quotes in tag attributes error (any help is appreciat

Got it! :roll:

Own stupid fault....was reversing the work done by htmlspecialchars.

Don't think anyone else will be dumb enough to do this, but if you do...shame on you :lol: (i meant, hope this helps)