CKEditor Mangles Source?

I can definitely confirm it, unfortunately I don't know if FCKeditor did it too, or this is a new issue?

Can you explain how linebreaks and spaces affect the rendering of HTML?

But I don't see any spaces when I insert two images in CKEditor. Do you?

The topic about "I want a wysiwyg editor but that doesn't touch my source code" is old. So old that it's boring. It has been explained a million times why it's this way.

In CKEditor you can configure the formatting of the output. I don't like the default values, but if you want to change those defaults (I mean not your installation but the values that are used for everybody), you'll have to provide real evidence that it's bad, not just that you don't like it.

Until the CKEditor gets smarter about tag formatting, you've got two choices: formatted (with your choice of indenting and spacing), and unformatted. Unformatted will preserve the spaces as you wish, but it leads to unintelligible code. When I hand-code HTML, I always format - so I actually appreciate the formatting performed by (F)CKEditor and am just fine with it being the default. So by assuming that your way is the universally correct way, "arrogant much" might apply to more than one side of this conversation...

The difference between my hand-formatting and the output from CKEditor is that I know when I don't want a space between images and other bits. This kind of intelligence sounds like an excellent development project for someone.

Also, an FYI: the HTML spec specifically states that line breaks immediately inside of tags are to be ignored, and that white space immediately inside of tags should not be relied upon - and in fact is also ignored in current browsers. http://www.w3.org/TR/html401/appendix/notes.html#notes-line-breaks

So the formatting you portray should cause no rendering issues and is syntactically correct.

csi95 wrote:

alfonsoml wrote:But I don't see any spaces when I insert two images in CKEditor. Do you?

The topic about "I want a wysiwyg editor but that doesn't touch my source code" is old. So old that it's boring. It has been explained a million times why it's this way.

In CKEditor you can configure the formatting of the output. I don't like the default values, but if you want to change those defaults (I mean not your installation but the values that are used for everybody), you'll have to provide real evidence that it's bad, not just that you don't like it.

Wow. Arrogant much?

Look, you can argue that "it doesn't matter" all you want, but the fact remains that the formatting is wrong, and the editor should not artificially be adding spacing and line breaks between the start of a block element and the actual contents.

As I said, I don't like the current output of CKEditor, but thanks to this post, now I just don't care.
I won't try to help to change it.

I posted about it ruining the html too. It is unusable as-is:

viewtopic.php?f=6&t=14493&p=38352&hilit=ckeditor#p38352

Surely it won't be released like this? Even if you want to format code, you must do that properly between block tags, not add breaks and spaces within block tags.

>>you can configure the formatting of the output

How do we do that to fix this problem? Or shut it off?

Otherwise very impressed with 3.0.

Thanks.

Can't believe this was released without fixing this ugly bug where it inserts characters inside block tags and ruins your html.

How can this be fixed so it formats correctly ONLY between block tags, or is overridden entirely?

Otherwise we have to write a parser to fix everything before it goes in the database. What a waste of time.

Anyone know how to overcome this bug or if it is being fixed?

As there is almost zero help on this forum, I'd best post the solution here for others:

http://dev.fckeditor.net/ticket/3260

I haven't tried it (or even fully deciphered it) and obviously it doesn't fix the fact that indentation is being done wrong and must take place between block tags, not within them, but could help...

I concur - the html output is unusable

I am parsing the html to a pdf script - the additional white space is causing numerous issues. Is that "evidence" enough that this should be fixed.

Other than this problem (and this arrogant reply - which devalues greatly CKSource in my view) - this is a helpful site and the code is solid.

Hi,

Any updates on this issue?

I just started using CK and I like it a lot, but this issue was a big problem for me.
I have output from CK going to an asp server where I can debug it. It seems the editor adds \n\t to certain things when content is submitted.
Well I cracked open the ckeditor.js and searched for "\n\t". Lo and behold, there was only 1 instance of this in the whole file. I ripped it out and now im having a much better day. Hope this helps.

Want to share where it was?

Why change ckeditor my code

<div style="page-break-after: always;"><span style="display: none;">&nbsp;</span></div>

in

<div style="page-break-after: always;">
<span style="display: none;">&nbsp;</span></div>

What can i do that ckeditor change not my code-position?

You can change the formatting of the source through CKEDITOR.dataProcessor.writer.setRules()

For Example, if you want to make sure <pre> tags are not formatted at all:

<textarea name="mytext" id="mytext" rows="7" cols="60"></textarea>
<script type=\"text/javascript\">
   CKEDITOR.replace( 'mytext', {
      on : {
         instanceReady : function( ev ) {
            this.dataProcessor.writer.setRules( 'pre', {
                  indent : false,
                  breakBeforeOpen : false,
                  breakAfterOpen : false,
                  breakBeforeClose : false,
                  breakAfterClose : true
               });
         }
      },
      customConfig : '/ck_custom/ckeditor_config.js',
   });
</script>

It's not a perfect solution, but if there are certain instances where source formatting is crutial, then this is a decent work-around.

J.

And (though this is, indeed, an ancient thread), this can even be easily configured for a group of elements; whichever elements you wish:
http://stackoverflow.com/a/7045742/717833

But here's what it says at that link, so you don't have to take the time to actually click it and read it...
==================

So, in my ckeditor_config.js file, after the CKEDITOR.editorConfig function, I put in this:

CKEDITOR.on('instanceReady', function( ev ) {
  var blockTags = ['div','h1','h2','h3','h4','h5','h6','p','pre','li','blockquote','ul','ol',
  'table','thead','tbody','tfoot','td','th',];

  for (var i = 0; i < blockTags.length; i++)
  {
     ev.editor.dataProcessor.writer.setRules( blockTags[i], {
        indent : false,
        breakBeforeOpen : true,
        breakAfterOpen : false,
        breakBeforeClose : false,
        breakAfterClose : true
     });
  }
});

That's where you're supposed to add it, the config.js file. I added this right above };

CKEDITOR.on( 'instanceReady', function( ev )
{
	var writer = ev.editor.dataProcessor.writer; 	
 	var dtd = CKEDITOR.dtd;	
	for ( var e in CKEDITOR.tools.extend( {}, dtd.$block, dtd.$inline ) )
	{
		ev.editor.dataProcessor.writer.setRules( e, {					
			breakBeforeOpen : true,		
			breakAfterOpen : true,
			breakAfterClose : false,
			breakBeforeClose : true
		});
	}
});

And it formatted the source.