We've found that 2.5 is URLencoding image filenames - in particular, turning spaces into %20 both in the image browser as well as in the HTML text of the editor.
I uploaded a file with spaces in the name in 2.4.2. On selecting that, the 2.4.2 FCKEDitor Image Properties dialog appears as in the first part of issue1054.png with spaces in the filename as expected. The link information in the HTML extracted from the editor is also correct.
If I switch to 2.5, the Image Properties dialog appears as per the second part of issue1054.png. The spaces have been replaced with %20. This can possibly be considered correct in that strictly speaking this is a URL so should be URLencoded. However, the HTML anchor shows the URLencoding which isn't correct:
<p>Test<img width=\"588\" height=\"368\" src=\"../../../user/data/FEditorUpload/Image/bung%20en%20dore.JPG\" alt=\"\" /></p>
Is there a switch to turn this behaviour off?
Hugh
I uploaded a file with spaces in the name in 2.4.2. On selecting that, the 2.4.2 FCKEDitor Image Properties dialog appears as in the first part of issue1054.png with spaces in the filename as expected. The link information in the HTML extracted from the editor is also correct.
If I switch to 2.5, the Image Properties dialog appears as per the second part of issue1054.png. The spaces have been replaced with %20. This can possibly be considered correct in that strictly speaking this is a URL so should be URLencoded. However, the HTML anchor shows the URLencoding which isn't correct:
<p>Test<img width=\"588\" height=\"368\" src=\"../../../user/data/FEditorUpload/Image/bung%20en%20dore.JPG\" alt=\"\" /></p>
Is there a switch to turn this behaviour off?
Hugh
Re: 2.5 is URLencoding image filenames
The change which has caused this is http://dev.fckeditor.net/changeset/342 . encodeURI was added when a selection was made in the file browser.
It appears that the most relevant bug report is at http://dev.fckeditor.net/ticket/261 - saying that URLs should be encoded in links.
However, the change made to "fix" the problem doesn't prevent URLs being encoded. For example, if I selected the "bung en dore.jpg" file in 2.5, then manually replace the %20 with spaces, the preview still works and the filename with spaces is put into the edited text.
In other words, as a server author I have no idea whether the filename is going to be encoded or not. The only thing I can do is to try and load the file as specified. If that fails, I can check if the decoded filename exists.
This doesn't seem very consistent. Wouldn't it be better to always call encodeURI on the output of the image browser dialog? That way it would be guaranteed that all image anchor URLs are encoded.
Hugh