1. Should it be possible to merge down cells from thead to tbody? 2. If so, should the merged cell be in thead or in tbody?
If they are really part of the header then it makes no sense to merge them with the data cells. They are part of different elements so they shouldn't be merged.
4. Should the merging of a th-cel with a td-cell result in a th-cell (it does at the moment) or a td-cell?
The current behavior is based on the top-left cell, there's no need to add extra rules (and code that must be written and tested). If the user doesn't like the output he can change the type of the merged cell.
If they are really part of the header then it makes no sense to merge them with the data cells. They are part of different elements so they shouldn't be merged.
I was a bit in doubt on this one. It should be possible to extend the thead. On the other hand: it's still possible to insert an extra row in thead and copy/paste data from tbody into it if needed.
We are under beta stabilization now, so I'm afraid those tickets will be retarget to a future release. Only critical tickets should be targeted to the 2.6.4 at this point.
Now right click in cell b and delete that column. You will see that the colspan of cell c is not lowered (or, in this case, removed).
To my opinion the best thing to handle those situations is to lower the colspan in cell c. It could be achieved bij making use of a tablemap when deleting a column.
The same issue appereas when deleting rows with rowspanning cells in it.
It would be definitely better to have those code simplifications and fixes when doing those operations. The current behavior doesn't bring that much problems, but it's always good if we can have a cleaner output.
I have a question. In Gecko one can only merge cells by selecting them all. In other browsers merging can only be achieved by putting the cursor into one cell and do 'merge right' or 'merge down'.
Wouldn't it be better to enable 'merge right' and 'merge down' in Gecko too? In that case 'merge right' and 'merge down' are enabled in all browsers and in Gecko 'merge' is enabled too.
Re: Improving the tables
If they are really part of the header then it makes no sense to merge them with the data cells. They are part of different elements so they shouldn't be merged.
The current behavior is based on the top-left cell, there's no need to add extra rules (and code that must be written and tested). If the user doesn't like the output he can change the type of the merged cell.
Re: Improving the tables
I was a bit in doubt on this one. It should be possible to extend the thead.
On the other hand: it's still possible to insert an extra row in thead and copy/paste data from tbody into it if needed.
Re: Improving the tables
Re: Improving the tables
Re: Improving the tables
Re: Improving the tables
We are under beta stabilization now, so I'm afraid those tickets will be retarget to a future release. Only critical tickets should be targeted to the 2.6.4 at this point.
Frederico Knabben
CKEditor Project Lead and CKSource Owner
--
Follow us on: Twitter | Facebook | Google+ | LinkedIn
Re: Improving the tables
Re: Improving the tables
Re: Improving the tables
Re: Improving the tables
Well ... I think it's unwanted.
Say we have a 3 * 2 table like this:
Now right click in cell b and delete that column.
You will see that the colspan of cell c is not lowered (or, in this case, removed).
To my opinion the best thing to handle those situations is to lower the colspan in cell c.
It could be achieved bij making use of a tablemap when deleting a column.
The same issue appereas when deleting rows with rowspanning cells in it.
Or should it be left the way it's working now?
Re: Improving the tables
Frederico Knabben
CKEditor Project Lead and CKSource Owner
--
Follow us on: Twitter | Facebook | Google+ | LinkedIn
Re: Improving the tables
Re: Improving the tables
Frederico Knabben
CKEditor Project Lead and CKSource Owner
--
Follow us on: Twitter | Facebook | Google+ | LinkedIn
Re: Improving the tables
Re: Improving the tables
b1
http://dev.fckeditor.net/ticket/2486
Re: Improving the tables
It's more an issue what the user expects.
I can live with it, because now the tablehandler continues the normal way of presenting cells (whereas I consider merged cells to be an exception).
Re: Improving the tables
http://dev.fckeditor.net/ticket/2813
http://dev.fckeditor.net/ticket/2800
Re: Improving the tables
http://dev.fckeditor.net/ticket/2859
Re: Improving the tables
In Gecko one can only merge cells by selecting them all.
In other browsers merging can only be achieved by putting the cursor into one cell and do 'merge right' or 'merge down'.
Wouldn't it be better to enable 'merge right' and 'merge down' in Gecko too?
In that case 'merge right' and 'merge down' are enabled in all browsers and in Gecko 'merge' is enabled too.
Re: Improving the tables
http://dev.fckeditor.net/ticket/2868
Thanks for the testing.
Thanks for the testing.
I guess that I might fix them as part of #1865 because I think that it might need a great review of all the code involved.