Improving the tables

info@fit2page.nl wrote:Yes I saw that the class is not picked up rightaway in IE6/7.
When I switch to "Code" and back then I see the class applied to the table.
In FF and Safari everything works fine.

alfonsoml wrote:That's because in IE you must use .className, just like other dialogs.

alfonsoml wrote:Yes, in the _dev folder there's a batch file to create the release version.

alfonsoml wrote:Run the build_release script from the command line so you can check for any error message (you need to have php installed in the computer)

alfonsoml wrote:About the styles, you can check the div container dialog, but remember that if you want to create a patch, it must work in all four browsers, including Opera, so I would suggest you to install it and add it to your tests.

alfonsoml wrote:About the styles, you can check the div container dialog, but remember that if you want to create a patch, it must work in all four browsers, including Opera, so I would suggest you to install it and add it to your tests.

alfonsoml wrote:

info@fit2page.nl wrote:

alfonsoml wrote:Run the build_release script from the command line so you can check for any error message (you need to have php installed in the computer)

Yeah I saw it; I have to install new virtual with Linux tomorrow...

No, you can install PHP in windows. I don't think that you can run the .bat file from Linux.

I've updated and fixed the patch to create THead in the tables. You can check the code in http://dev.fckeditor.net/ticket/2430#comment:1

As I said, if anyone is interested in making this support a reality, this is the time to give a hand and test the patch, check that it works as expected, and that it doesn't have any problem. If it is successfully tested then it will be much easier to ask for a review of the code by Fred or Martin.

http://dev.fckeditor.net/ticket/547
.......
# summary changed from Add CLASS and ID properties on TABLE and TD window (at least) to Add CLASS and ID properties to tags

alfonsoml wrote:

info@fit2page.nl wrote:
OK thank you.
Do you have a howto or a link. What about the chance that my IIS configuration on the machine is destroyed by the PHP installation?

Marc

I don't think that your IIS installation should be affected. Usually people want to install PHP in order to run it for webpages and they get troubles to make it work, I guess that if you skip that step you won't have any trouble.

Anyway, remember that you don't need PHP to test these changes, and that hopefully they will become a new version so you can grab that zip and deploy it.

I have tested with IE6 and I didn't notice any problem with the summary field. I don't know what to do if I can't reproduce the problem...

alfonsoml wrote:

The change at the beginning of both files means that probably your editor isn't handling the UTF-8 marker correctly and it's removing it, not a big issue.

Anyway, I can see some issues: copying the attributes to an array and storing first the name and then the value looks strange. It would be better to copy all the attributes and values to an object.
Then the conversion to a string and then splitting it again seems useless.

I would try to use the CopyAttributes function defined in the fck_dialog_common.js (moving it to the domtools)

The main problem is that in order to fix other bugs (that are triggered more easily like the context-menu at last row) I think that the _CreateTableMap and _InstallTableMap might need several revisions, that are more important than this issue at hand. After all, a user can't set any attribute on a <tr>, but as I said, there are other things that seem that should be fixed first.

Having a function named CopyAttributesToArray that returns an object looks really strange.

To me it looks strange that the functions added to fckdomtools are asymetric. One takes care of doing all the loop, but the second one only applies one attribute at a time.

The logic about rowCount is flawed.

   /**
    * Returns all attributes of the element as an object.
    */
   GetAllAttributes : function ( element )
   {
      var elementAttributes = {} ;
      var oAttributes = element.attributes;
      
      for ( var i = 0 ; i < oAttributes.length ; i++ )
      {
         // Check for "specified" attributes on the element.
         if( oAttributes.item(i).specified )
         {
            elementAttributes[oAttributes.item(i).nodeName] = this.GetAttributeValue( element, oAttributes.item(i).nodeName ) ;
         }
      }
      return elementAttributes ;
   },

   /**
    * Set all attribute values of the element.
    *   @param {Object} element: The element whose attributes will be set.
    *   @param {Object} attributeList: The list of attributes as a name/value pair object.
    */
   SetAllAttributes : function( element, attributeList )
   {
      for ( var attributeName in attributeList )
      {
         // Workaround for IE when setting the "style" or "class" attributes.
         if ( FCKBrowserInfo.IsIE && attributeName == 'style' )
            element.style.cssText = attributeList[attributeName];
         else if ( FCKBrowserInfo.IsIE && attributeName == 'class' )
            element.setAttribute( 'className', attributeList[attributeName] ) ;
         else
            element.setAttribute( attributeName, attributeList[attributeName] ) ;
      }
   },

I don't know why you can't reply to the ticket. Do you get any error?