feature request - SelectFunction by reference

The SelectFunction must be on the window scope for the CKfinder to be able to find it, but I would like to be able to have it on an object. For this the function would be able to be passed to the CKfinder by reference and not as string. See discussion at viewtopic.php?f=10&t=10766&p=28534.

Or is this possible since 1.3?
In the docs, http://docs.fckeditor.net/CKFinder/SelectFunction, the first code reads "finder.SelectFunction = ShowFileInfo ;", so is that a reference?
As a possible alternative I thought maybe that the scope can now be passed in the SelectFunctionData, but by looking at the code example that seems not the case.

Wed, 12/17/2008 - 13:27

wiktor

Joined: 16/07/2007

Posts: 1641

Re: feature request - SelectFunction by reference

Hmm it seems doable, but it's not straightforward. Take a look at the following code:

var MyObject = 
{
   Foo : 'bar',
   
   ShowFileInfo : function ( fileUrl, data )
   {
     alert( 'The selected URL is "' + fileUrl + '". Foo: ' + this.Foo ) ;
   }
}

MyObject.Foo = 'baz' ;

function MySelectFunction( fileUrl, data ) {
  return MyObject.ShowFileInfo( fileUrl, data ) ;
}

var finder = new CKFinder() ;
finder.BasePath = '../../' ;
finder.SelectFunction = MySelectFunction ;
finder.Create() ;

Wiktor Walc
CTO, CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+

Wed, 12/17/2008 - 14:07

saul11

Joined: 19/06/2006

Posts: 633

Re: feature request - SelectFunction by reference

Well then still the callback is in the window scope, an extra function that just only triggers the object's function...

What I would like to do is get an object's function called directly:

var MyObject =
{
   ShowFileInfo : function ( fileUrl, data )
   {
     alert( 'The selected URL is "' + fileUrl) ;
   },

   OpenFileBrowser: function ()
   {
     var finder = new CKFinder() ;
     finder.BasePath = '../../' ;
     finder.SelectFunction = (function (scope) {
          return function(fileUrl, data)
          {
               (function(){
                    this.ShowFileInfo(fileUrl, data);
               }).call(scope);
          }
     })(this);
     finder.Create() ;
   }
}

Thu, 12/18/2008 - 16:53

wiktor

Joined: 16/07/2007

Posts: 1641

Re: feature request - SelectFunction by reference

Oh I see now what you mean, thanks for your suggestions.

Wiktor Walc
CTO, CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+