CKEditor 4
Wed, 04/16/2008 - 22:58
#1
jphilip
jphilip's picture
Joined: 16/04/2008
Posts: 7

Dynamic base directories and ACL

What would be the best way to use CKFinder with one base directory per user in the PHP version ?
I found how to dynamically set the Base directory per user with session variables, but I would need the ACLs to come from my database instead of the config file.
My database defines permissions per user, they would have to replace the ones coming from the config file.
Thank you for your time.
Top
Thu, 04/17/2008 - 07:13
wiktor
wiktor's picture
Joined: 16/07/2007
Posts: 1641

Re: Dynamic base directories and ACL

I think you have already found the answer.
Config file is executed on each request by PHP connector.

So you can use in config.php something like that for example:
...
//default ACL for unathenticated user
$config['AccessControl'][] = Array...
...
// load ACL for user X
load_user_permissions_from_db_and_fill_the_ACL_array($config);
...


Note that if user X is logged in, you don't have to add to $config['AccessControl'] ACL settings for all other users.
Of course you don't need to load permissions from DB every time, you can cache them.

Wiktor Walc
CTO, CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+

Top
Thu, 04/17/2008 - 07:56
jphilip
jphilip's picture
Joined: 16/04/2008
Posts: 7

Re: Dynamic base directories and ACL

Thank you, actually I am using Symfony and the credentials are already stored in the session at login, so I should not even have to call the DB.

Now I have another question:
I have an Image table in the DB where I keep track of the images so they can be linked to other records...
How can I keep the Image table in sync with the images being uploaded renamed or deleted ?
Is there a way without modifying the source code of the commands ?
Top
Thu, 04/17/2008 - 09:01
wiktor
wiktor's picture
Joined: 16/07/2007
Posts: 1641

Re: Dynamic base directories and ACL

We are considering creating a hook system in the future.
This way it would be possible to inject your own code into connector and easily upgrade in the future.

For now, I'd suggest creating your own hook system.
This way you can reduce changes in the core to the minimum.
After creating all necessary changes in the core, save your changes as a diff file to be able to apply same changes in the future.

example:

in config.php, create a $ckfinderHooks array and add your hook to the global array of hooks:
$ckfinderHooks = array();
$ckfinderHooks['afterDeleteFile'][] = 'my_custom_function';

in core\connector\php\php5\CommandHandler\DeleteFile.php
after:
if ($bDeleted) {

add:
if ($bDeleted) {
   ckfinder_hook('afterDeleteFile', array($fileName, $filePath) );

ckfinder_hook function should use $ckfinderHooks array to find all hooks that have to be executed and launch them with call_user_func_array().

In the example above, we could have:
function afterDeleteFile($fileName, $filePath) {
  ...
  mysql_query("DELETE FROM files WHERE...")
  ...
}


Similar trick may be used in all other commands (Fileupload, RenameFile, DeleteFolder etc.)

Wiktor Walc
CTO, CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+

Top
Thu, 04/17/2008 - 09:28
jphilip
jphilip's picture
Joined: 16/04/2008
Posts: 7

Re: Dynamic base directories and ACL

Thank you so much, that sounds good, I will do that.
Top
Fri, 04/18/2008 - 10:32
jphilip
jphilip's picture
Joined: 16/04/2008
Posts: 7

Re: Dynamic base directories and ACL

Hi again,

Things are going rather good, but I have a problem when I want to send a custom error to the browser using for example:
 $this->_errorHandler->throwError(1, 'Error updating the database for file deleted.');

The XML sent to the browser seems good:
<?xml version="1.0" encoding="utf-8"?><Connector resourceType="Images"><Error number="1" text="Error
 updating the database for file deleted." /><CurrentFolder path="/" url="/client-files/27/images/" acl
="255" /><DeletedFile name="pgp6_js_mcgrath1.jpg" /></Connector>

The error is:
A has no properties
Line 34
var ao={es:function(A,B){var C=new RegExp('(?:[\?&]|&amp;)'+A+'=([^&]+)','i');va...

For upload, I get around by calling directly:
echo "<script type=\"text/javascript\">";
echo "window.parent.OnUploadCompleted(1, '', 'Error saving the file info to the database');";
echo "</script>";
, but for delete I did not find a workaround.

Any idea?
Top
Fri, 04/18/2008 - 11:11
wiktor
wiktor's picture
Joined: 16/07/2007
Posts: 1641

Re: Dynamic base directories and ACL

Before I start debugging this, one question: is this really something that should be displayed to the user?
Maybye if there is a problem with database, just save some debug info into the text file and try to execute all those queries as soon as the database is available (after checking if it is still required to run this query).

Wiktor Walc
CTO, CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+

Top
Fri, 04/18/2008 - 20:33
jphilip
jphilip's picture
Joined: 16/04/2008
Posts: 7

Re: Dynamic base directories and ACL

Yes I do log the error too and I can run a script to synchronize the DB with the file system once in a while, but sending an appropriate message to the user is always good, I guess I could send an unknown error with CKFINDER_CONNECTOR_ERROR_UNKNOWN that works fine.
One case where I would need to send a user defined message is for Folder Delete because I don't want people to delete non empty folders as it is a pain to update the DB recursively, but I guess I could just disable Folder Delete in the context menu by setting the Folder Delete bit to 0 when the folder is not empty.
In that case, I tried in GetFolders.php before creatinf the node :

//Remove folder delete bit acl if not empty
if (CKFinder_Connector_Utils_FileSystem::hasChildren($this->_currentFolder->getServerPath()))
    $aclMask = $aclMask & (~CKFINDER_CONNECTOR_ACL_FOLDER_DELETE);


but it disables the node even when the folder is not empty.
Top
Fri, 04/18/2008 - 20:46
jphilip
jphilip's picture
Joined: 16/04/2008
Posts: 7

Re: Dynamic base directories and ACL

Sorry on the last line, I mean even when the folder IS empty.
Top
Fri, 04/18/2008 - 21:47
jphilip
jphilip's picture
Joined: 16/04/2008
Posts: 7

Re: Dynamic base directories and ACL

OK, sorry I got it to work, the hasChildren method looks only for folders and I had the wrong argument too.
This works:

//Remove folder delete bit acl if not empty
if (has_folders_or_files($_sServerDir . $file))
    $aclMask = $aclMask & (~CKFINDER_CONNECTOR_ACL_FOLDER_DELETE);


and the function:

function has_folders_or_files($serverPath)
{
    if (!is_dir($serverPath) || (false === $fh = @opendir($serverPath))) {
        return false;
    }
    
    $hasChildren = false;
    while (false !== ($filename = readdir($fh))) {            
        if ($filename == '.' || $filename == '..') {
            continue;
        } else {
            //we have found valid directory or file
            $hasChildren = true;
            break;
        }
    }

    closedir($fh);

    return $hasChildren;        
}


It might be good in a future version to have a configuration option to not be able to delete non empty folders.
Top
Fri, 04/18/2008 - 22:26
alfonsoml
alfonsoml's picture
Joined: 31/12/2006
Posts: 3737

Re: Dynamic base directories and ACL

JPhilip wrote:
It might be good in a future version to have a configuration option to not be able to delete non empty folders.


I agree.
Top
Twitter Facebook Facebook Instagram Medium Linkedin GitHub Arrow down Phone Menu Close icon Check