Youtube Plugin CKeditor

Hi Roderik,

thanks a lot for for your implementation and for sharing it with the CKEditor community.

I downloaded your code and gave it a quick test. The plugin works, so congratulations on that

My first comment: it would be nice to be able to download the uncompressed source code in the development phase as its production form does not look too readable, especially if you want to encourage others to check and comment it.

Second thing: the dialog window states: "Please copy and paste the Youtube URL here", but in YouTube's case it is not entirely clear which URL you really mean: the one from the browser's address bar (http://www.youtube.com/watch?v=XXXXXX), the "Share" link (http://youtu.be/XXXXXX) or the "Embed" code/link (<iframe title="YouTube video player" width="640" height="390" src="http://www.youtube.com/embed/Y4AFfpytCWU" frameborder="0" allowfullscreen></iframe>). Different YouTube solutions available not just for CKEditor, but for various forum/blog etc. engines require different approaches and end-users might be confused as to what you really mean.

As for the dialog window, why make it so huge? I see no reason for a dialog window that just contains one text field to be bigger than standard CKEditor dialog windows.

The text field is also missing the type="text" declaration and so the cursor is wrong.

Last but not least, the plugin does not support editing an already pasted YouTube video -- both the context menu and the double-click action opens the IFrame Properties dialog window and not your custom YouTube plugin dialog window. This may or may not be the desired behaviour, depending on your purpose.

Finally, the official spelling is "YouTube", so I would recommend sticking to that.

Just my two cents and thumbs up for the next revision. Thanks again for posting it!

I noticed that the plugin button was not visible in Firefox 8.0.1 in the toolbar and I had to undergo the following steps to have it working:

0) please do include a small readme in your tar-file how to install and integrate the plugin (maybe with a small info how to add language codes )

1) as everything seems to be casesensitive, I defined the toolbar entry in small letter:

 'youtube'

I checked the files which are contained in your package and I have some points:

1)
the language file uk.js is really wrong

CKEDITOR.plugins.setLang('vimeo', 'en',
{
  vimeo : 
  {
    title : "Embed Vimeo Video",
    button : "Embed Video",
    pasteMsg : "Please copy and paste the Youtube URL here"
  }
});

Its not working w/ the new url addressing scheme that YouTube provides.

Example: http://youtu.be/Qdoe_gI_fSs

Weird how they have changed this.

you can now put sharing address like.. http://youtu.be/9eYTgSGbb_M .. and popup box resizing and small logo..