Two new skins: Office2003Blue + SilverNarrow

!! All skins MUST have a height definition for the classes '.TB_Button_Off, .TB_Button_Disabled, .TB_Combo_Off, .TB_Combo_Disabled' in their fck_editor.css to make the button opacity work for IE (i.e. get the possibility of greyed out buttons)

http://www.saulmade.nl/FCKeditor/

http://wiki.fckeditor.net/Developer%27s ... c443c8a821

I would like to suggest some code changes for improving the freedom of skins designers and improving compatibility between skins.

Everywhere in the code a width and hight attribute is used in the IMG tag. Of course these *default* values for the images' dimensions can be overridden by skin CSS. But I think it isn't bad to remove these default sizes. With the defaults the skin designers are forced to set the images height and width in the CSS files. Without them, the images their actual size would be used...
Moreover, icons aren't interchangeable this way (that is, if they aren't the default size) !

The files that have these hardcoded defaults are: _source/classes/fcktoolbar.js; _source/classes/fcktoolbarbutton.js; _source/classes/fcktoolbarpanelbutton.js and
_source/classes/fckcontextmenuitem.js
(I'm not sure if these are them all though).

A minor suggestion is the next one: I think it would be good to give the toolbar seperator a class too. That would be in _source/classes/fcktoolbar.js. Adding to the function 'AddSeparator' the next line:
oCell.className = 'TB_Separator' ;

Another suggestion, one about combo boxes :
I have been trying to get padding on the comboboxes. (So that e.g. the format combobox would be able to get a space before its fieldCaption and after its fieldButton) This by use the existing classes and by changing the code and assigning a new overall class. But without success.
Wouldn't it be an idea to let the combobox have a 'SC_Combo' class assigned to its top level so that padding can be assigned easily, giving the skin designers even more freedom?


Question about item mouseover background images :
I've used a new background image ('toolbar.itemhoverbackground.gif') to colorize the background of the toolbar items. But in IE it must allways reload onmouseover of every item so it seems. Can't this be cached in some way?

http://www.saulmade.nl/FCKeditor/

This is becuase the skins are not yet compatible with FCKeditor2.3

Frederico, or anyone involded in the changes made to the skin system between 2.2 and 2.3, why are all images now in one file/strip? Isn't that making it hard to add items in the future? Also, could you tell me or give an indication of the steps I have to undertake to upgrade skins to 2.3? E.g. Are classNames changed?

http://sourceforge.net/tracker/?group_i ... tid=740153


http://www.saulmade.nl/FCKeditor/FCKSkins.php

http://sourceforge.net/forum/forum.php? ... _id=257179