At the FileWorkerBase.cs
the ff should be interchange because DEFAULT_USER_FILES_PATH has a constant value and will never process the check for ServerPath.
// Otherwise use the default value.
if ( sUserFilesPath == null || sUserFilesPath.Length == 0 )
{
sUserFilesPath = DEFAULT_USER_FILES_PATH ;
}
// Try to get from the URL.
if ( sUserFilesPath == null || sUserFilesPath.Length == 0 )
{
sUserFilesPath = Request.QueryString["ServerPath"] ;
}
the ff should be interchange because DEFAULT_USER_FILES_PATH has a constant value and will never process the check for ServerPath.
// Otherwise use the default value.
if ( sUserFilesPath == null || sUserFilesPath.Length == 0 )
{
sUserFilesPath = DEFAULT_USER_FILES_PATH ;
}
// Try to get from the URL.
if ( sUserFilesPath == null || sUserFilesPath.Length == 0 )
{
sUserFilesPath = Request.QueryString["ServerPath"] ;
}
RE: .NET UserFilePath Bug
I think I'll probably remove the possibility to load it from the QueryString.
It would be nice to have opinions from all you.
BR,
FredCK
Frederico Knabben
CKEditor Project Lead and CKSource Owner
--
Follow us on: Twitter | Facebook | Google+ | LinkedIn
RE: .NET UserFilePath Bug
Please leave that handy feature, but warn the user of the potential problem, if not cared of (just as the browsers being disabled by default, until explicitly enabled)
RE: .NET UserFilePath Bug
It would probably be best to seperate the connectors from the editor itself. Offer them as a seperate, seamless to intall package.
Just thoughts... =]
RE: .NET UserFilePath Bug
This is way a server side option is the option. Today it can be done with an Application var, a Session var and a Web.config setting.
In some way it is a bad software design to leave security holes if we now they exist.
Please leave your comments (all you).
Frederico Knabben
CKEditor Project Lead and CKSource Owner
--
Follow us on: Twitter | Facebook | Google+ | LinkedIn
RE: .NET UserFilePath Bug
But, still, I'd prefer the solution be *not* server dependant, if at all possible (cookies might be the only choice then, or not?)