The forum operates in read-only mode. Please head to StackOverflow for support.

Last post

Fri, 01/31/2014 - 04:08

timothy_lim

Joined: 03/04/2012

Posts: 7

List Items incorrectly inheritting / using parent div's style

Copying the following HTML into CKEditor and making a list causes the LI items to copy the styles of the parent div.

Is there a way to fix this? Or prevent inheriting styles from the parent?

HTML in question:

<div style="margin: 20px;margin-left: 30px; border: 1px solid black;">highlight<br />
these words<br />
and make a list<br />
each <li> uses the parent <div>'s style attribute making it look weird</div>

<hr /><br />
This is an email from the fictional organisation
<p> </p>
</td>
</tr>
</tbody>
</table>

Attachments:

before.png

after.png

webpage.txt

Fri, 01/31/2014 - 11:26

sebstefanov

Joined: 03/02/2012

Posts: 1329

In the demo I get the after

In the demo I get the Before version. Maybe ACF is stripping some of the code. Would be nice to have the before and after code.

Customer and Community Manager, CKSource
Follow us on: Facebook, Twitter, LinkedIn

If you think you found a bug in CKEditor, read this!

Mon, 02/03/2014 - 00:04

(Reply to #2) #3

timothy_lim

Joined: 03/04/2012

Posts: 7

All the files I provided show

All the files I provided show how I used CKEditor. I managed to do the same thing in the demo http://ckeditor.com/demo#full

Go to the demo page http://ckeditor.com/demo#full
Click "Source"
Copy and paste the HTML
<table border="0" cellpadding="0" cellspacing="0" style="width:800px">
<tbody>
<tr>
<td>
<p><img alt="logo" src="logo" style="height:50px; width:500px" /></p>

<div style="margin: 20px;margin-left: 30px; border: 1px solid black;">highlight<br />
these words<br />
and make a list<br />
each <li> uses the parent <div>'s style attribute making it look weird</div>

<hr /><br />
This is an email from the fictional organisation
<p> </p>
</td>
</tr>
</tbody>
</table>
Click "Source" again to show the rich text editor
Highlight the 4 lines in the paragraph ("hightlight these words... making it look weird")
Click on the "Insert/Remove Bulleted List"

Hope that is clearer.

Attachments:

Attachment	Size
1 view source and paste html.png	144.5 KB
2 before pressing list button.png	130.33 KB
3 after pressing list button.png	123.96 KB

Wed, 06/11/2014 - 19:41

(Reply to #3) #4

fruitbatinshades

Joined: 25/06/2008

Posts: 40

I've got exactly the same

I've got exactly the same issue.

I changed the template plugins source file and added my own ones. The html is valid and parses correctly but when you try and edit the areas in the template the parent attributes are copied.

<div class="innerContent"></div>

get converted to this when you add anything in that div:

<div class="innerContent">
  <h1 class="innerContent">Title</h1>
  <ul class="innerContent">
    <li class="innerContent">Item One</li>
  </ul>
</div>

Thu, 06/12/2014 - 10:34

(Reply to #4) #5

fruitbatinshades

Joined: 25/06/2008

Posts: 40

Just to add the config. I've

Just to add the config. I've forced the P and BR in case it was the div handler.

config.allowedContent = true;
config.enterMode = CKEDITOR.ENTER_P;
config.shiftEnterMode = CKEDITOR.ENTER_BR;

I'm looking at filter.js and think the culprit may be nested calls to updateAttributes and updateElement.

Can anyone help?

Thu, 06/12/2014 - 16:32

sebstefanov

Joined: 03/02/2012

Posts: 1329

Ok, I asked one of the devs

Ok, I asked one of the devs and this is apparently correct behaviour, or at least a behaviour he would expect. When you have a selection in this kind of HTML:

You see 3 lines of text and your caret is in the 2nd one. When you press the list button I would expect to turn only the line in which I have selection into a list. The case with <div> is more complex, but it can be simplified to this scenario.

Another scenario:

When you change format to Heading 1. This time entire paragraph is turned into ha <h1>. Why? Well... this can be considered inconsequent, but there are no good answers unfortunately. It would be better if we were consequent (for us), but people would still complain.

Customer and Community Manager, CKSource
Follow us on: Facebook, Twitter, LinkedIn

If you think you found a bug in CKEditor, read this!

Thu, 06/12/2014 - 16:38

(Reply to #6) #7

fruitbatinshades

Joined: 25/06/2008

Posts: 40

Hi sebstefanov,

Thanks for having a look :) I don't see how your comment relates to children inheriting the parent classes though? :/