Enhanced image widget wrong way to add height and width?

The standard image plugin add height and width using "style":

<img alt="" src="images/picture.jpg" style="height:350px; width:350px" />

The enhanced image plugin/widget uses height = xxx (before the src !) and width = xxx (after src).

<img alt="" height="350" src="images/picture.jpg" width="350" />

This causes trouble in my generation of PDFs. I think the use of "style" is more in line with modern CSS?

Sun, 11/17/2013 - 10:08

flh

Joined: 20/03/2013

Posts: 94

I was wrong :-)

I solved by PDF generation by changing my PHP explode code.

Did some more search on the order of attributes inside the IMG tag. Seems there are no strict rules...

I searched Google for different orders of the attributes - not sure they entirely reflect only IMG tags, but it seems that the winner is:

src width height alt. First column is number of search results. Having the "height" to the left of src and the "width" to the right of src is not very common.

65 200 000	img	alt	src	width	height
1 840 000 000	img	src	width	height	alt
149 000 000	img	src	height	width	alt
73 900 000	img	height	src	width	alt
118 000 000	img	alt	height	src	width
67 400 000	img	alt	src	style	width	height

Perhaps as a recommandation, the same order should be used in the old Image plugin and the new Image2 widget plugin.

Use of "style" as I suggested is not a particular recommandation, so sorry for that :P

Mon, 11/18/2013 - 15:37

sebstefanov

Joined: 03/02/2012

Posts: 1329

Still, thanks for sharing

Still, thanks for sharing this info with the rest of us!

Customer and Community Manager, CKSource
Follow us on: Facebook, Twitter, LinkedIn

If you think you found a bug in CKEditor, read this!

Mon, 11/18/2013 - 19:36

reinmar

Joined: 24/08/2012

Posts: 631

This causes trouble in my

This causes trouble in my generation of PDFs. I think the use of "style" is more in line with modern CSS?

No, it's not. Especially taking into consideration responsive design. It was a mistake done many years ago that image plugin started setting dimensions by inline styles and after dozens of request from other developers we changed that back to the more correct attributes.

PS. Regarding the order of attributes - it's insignificant for semantics. We're sorting attributes alhpabetically and it's completely correct.

Piotrek (Reinmar) Koszuliński
CKEditor JavaScript Developer
--
CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+

Tue, 11/19/2013 - 01:14

(Reply to #4) #5

synchro

Joined: 10/12/2007

Posts: 64

I was one of those requesters

I was one of those requesters, and I'm very grateful you made that change!