Hi.
I git checkoutted tag 4.1 of https://github.com/ckeditor/ckeditor-dev.git and built it using build.sh. When trying in \dev\builder\release\ckeditor\samples\replacebycode.html using the IE9 Developer console CKEDITOR.version returns "4.0 DEV", when "4.1" or "4.1 custom" or "4.1 something" was expected. It appears to be 4.1 because the bug that happens with source mode + undo appears to be fixed.
Did I do something wrong?
We hadn't yet updated dev
We hadn't yet updated dev versions. I've just pushed a commit to master which fixes that.
Piotrek (Reinmar) Koszuliński
CKEditor JavaScript Developer
--
CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+
Wait... what?
Sorry for being an idiot, but I'm beyond confused at the moment.
How is the dev repo tag 4.1 code different from the release repo tag 4.1/*? I imagined that the process went like so: when the current dev is ready for release it is tagged with the version number, then the contents of that tag is used to build the different versions of ckeditor-releases with the new tags 4.1/full, 4.1/basic and 4.1/standard and that's it.
I though when something was tagged X that the contents of that tag would be set in stone and eternal. What I'm trying to do is use my own build-config.js to build myself CKEditor 4.1 with the plugins of my choosing so I figured I would just get the contents of the 4.1 tag, edit it and build that with the awesome builder. If that's wrong, what should I do?
How would it be possible to push to a tag then and if tags change in dev after releases, what's the point of tags? Or do tags behave like branches that have their own HEAD? I'm so confused, sorry! :D
I haven't updated any tags
I haven't updated any tags (except small fix in ckeditor-presets repository, but let's say... no one has seen that :P).
Tags in ckeditor-dev are untouchable. I've only pushed commits to major and master. Tags mean points at which we made the release, however, to create a release we do not use the dev builder - this one exists mainly for the dev purposes. For releases we use ckeditor-presets.
This is very close to how we really do this. Final releases are created using the online builder, which is based on a builder which you can find ckeditor-presets (with small, irrelevant differences). We do not use dev builder to create release, therefore the version set in ckeditor-dev/dev/builder/build.sh contains the "DEV" word. Version in ckeditor-presets does not. But as I said - there are small differences between what ckeditor-presets build and what can be downloaded. E.g. ckeditor-presets includes preset name in the version.
I know that this is... complicated. But in short: you can safely use in production environment CKEditor built by dev builder and presets builder. JS code is built and compressed by the same system, however the packages may differ slightly (version, included build-config.js, etc).
And if you want to have identical CKEditor's code that was included in the official releases, just set the HEAD of CKEditor submodule (or repo) to a chosen tag.
... I hope that explained that clearly. If not - feel free to ask more questions :).
Piotrek (Reinmar) Koszuliński
CKEditor JavaScript Developer
--
CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+