plugin problem with this.setValue

Hi,

I've encountered a bug with CKEditor 3.3.1

Problem: Unable to set a border of zero (0) and have it retain after closing/re-opening image dialog.

I'm inside "plugins/image/diaglogs/image.js"... I found out it is properly parsing and finding a border size of zero, and when it does this: this.setValue(value) it does not like the integer zero being passed to it. I added this little snip:

if (value == 0)
{
   this.setValue('0');
}
else
{
   this.setValue(value);
}

and that seems to work. so setValue doesn't seem to like getting a zero passed to it.

Sat, 06/19/2010 - 06:40

pircio

Joined: 13/03/2008

Posts: 20

Re: plugin problem with this.setValue

this also happens in 3.2.2

Fri, 09/10/2010 - 17:20

pircio

Joined: 13/03/2008

Posts: 20

Re: plugin problem with this.setValue

FYI this is still a problem in 3.4

Fri, 09/10/2010 - 21:54

zanpakutō

Joined: 08/02/2010

Posts: 122

Re: plugin problem with this.setValue

FYI : This forum is not a place to add bug reports. http://dev.ckeditor.com/ is.
This is not a bug because the correct css propery for no border is none and not zero.
http://www.w3schools.com/css/css_border.asp

The correct CSS is :

img{border:none}

Tue, 09/28/2010 - 18:14

pircio

Joined: 13/03/2008

Posts: 20

Re: plugin problem with this.setValue

I'm talking about the <img> border attribute, not a style setting.

the expected use of the dialog is not working properly. when upgrading from FCKeditor 2.x, it used the border attribute, not the style attribute. it doesn't even use the "border" property of the style attribute... it uses border-width, which CAN be set to 0px, FYI... so please, don't lecture me on what's wrong or right

ckeditor is settings the value in the border input box of the image dialog to be "border-width: #px" ... so zero is clearly a valid entry here

Tue, 09/28/2010 - 22:19

zanpakutō

Joined: 08/02/2010

Posts: 122

Re: plugin problem with this.setValue

pircio wrote:I'm talking about the <img> border attribute, not a style setting.

Well why did you NOT make that clear then? The border attribute of images was depreciated in HTML 4 STRICT.
Even though CKEditor uses the transitional doctype by default, I expect it is only for compatibility reasons and HTML 4 STRICT + HTML 5 is aimed for. TRANSITIONAL is for legacy code. When writing new code use STRICT. That is the W3C recommendation.

So, I wouldn't hold out for much help with a depreciated HTML tag from anyone. Let alone if you are just plain rude.

Also, your javascript "Snippet" above is garbage. Checking and setting something to zero isn't done like that.
Your favourite on line book store will have many titles available for you to read to learn javascript. Read one and you may understand why not.

Good luck with your problem.

Thanks,
Zanpakutō