The forum operates in read-only mode. Please head to StackOverflow for support.

Sun, 04/03/2011 - 14:08

datalink

Joined: 18/10/2007

Posts: 149

insert javascript execute the script

Hi,

I write a dialog plugin for inserting javascript to head section.

    ...
    onOk : function()
    {
        var head = CKEDITOR.instances.metas.document.getHead();
        var script = CKEDITOR.dom.element.createFromHtml( '<script type="text/javascript" src="' + myScriptPath + '"></script>' );
        head.append( script );
    }
    ...

This works. The script is inserted as last child of <head>. But...

If there is something like alert('test'); in script, the alert is execute. How can I avoid execution of inserted scripts? Is there a way or is it a bug in ckeditor?

Same problem with:

    ...
    onOk : function()
    {
        var head = CKEDITOR.instances.metas.document.getHead();
   head.append( CKEDITOR.document.createElement( 'script', {
         attributes : {
            type : 'text/javascript',
            src : myScriptPath
         }
      })
   );
    }
    ...

Thanks for advice

Mon, 04/04/2011 - 09:04

itsmeup

Joined: 01/04/2011

Posts: 3

Re: insert javascript execute the script

I think this is standard browser behaviour. CKEditor does not do this. Create functions in your file, and they will be executed only when called.

Mon, 04/04/2011 - 17:47

datalink

Joined: 18/10/2007

Posts: 149

Re: insert javascript execute the script

I have same functionality in old FCKeditor version and there javascript isn't executed by inserting. So I think it's a bug in ckeditor or it's a mistake in my script.

Mon, 04/04/2011 - 20:37

itsmeup

Joined: 01/04/2011

Posts: 3

Re: insert javascript execute the script

Try any code that inserts js link to head, and you will see that it loads and then runs immediately.

Mon, 04/04/2011 - 22:18

datalink

Joined: 18/10/2007

Posts: 149

Re: insert javascript execute the script

hmm...

<textarea>
<script type="text/javascript" src="myscript.js"></script>
</textarea>

doesn't execute myscript.js (and if it's inserted in sourcemode too). What's different to

var head = CKEDITOR.instances.metas.document.getHead();
head.append( CKEDITOR.dom.element.createFromHtml( '<script type="text/javascript" src="' + myScriptPath + '"></script>' ) );

where metas is the name of my textarea? Or is this functionality not available yet? I think it's the wrong way to insert a script to header source (config.fullPage : true), but I can't take the insertHtml methode, because I don't know where the cursor is placed. I have multible editors, where metas is the editor for header tags and placed outside my page (invisible).

Tue, 04/19/2011 - 15:40

datalink

Joined: 18/10/2007

Posts: 149

Re: insert javascript execute the script

Find a solution

var head = CKEDITOR.instances.metas.document.getHead();
head.append( CKEDITOR.dom.element.createFromHtml( '<script type="text/javascript" data-cke-saved-src="' + myScriptPath + '"></script>' ) );

Wed, 04/20/2011 - 04:35

paul ellis

Joined: 20/04/2011

Posts: 5

Re: insert javascript execute the script

I agree with datalink
I think it's bug in that version.

Paul Ellis

Thu, 04/21/2011 - 22:44

datalink

Joined: 18/10/2007

Posts: 149

Re: insert javascript execute the script

No it isn't a bug. Change 'src' to 'data-cke-saved-src' and it work's.

Tue, 09/13/2011 - 14:41

aaminah1978

Joined: 10/08/2011

Posts: 8

Re: insert javascript execute the script

who did you make the change to

var head = CKEDITOR.instances.metas.document.getHead();
head.append( CKEDITOR.dom.element.createFromHtml( '<script type="text/javascript"
data-cke-saved-src="' + myScriptPath + '"></script>' ) );

I checked and it appears to work

Tks Aaminah

Thu, 04/25/2013 - 15:38

#10

olli9000

Joined: 25/04/2013

Posts: 3

This dont work with ckeditor

This dont work with ckeditor 4. Can someone help me??

Thu, 04/25/2013 - 17:12

#11

olli9000

Joined: 25/04/2013

Posts: 3

Anyone?? All what i need, is

Anyone?? All what i need, is a draggable div. So i think, if you can insert the jquery lib and jquery ui in the iframe, you can work with jquery ui functions... or is there another way to make a div container draggable..?

Fri, 07/04/2014 - 16:23

#12

DieterAtWork

Joined: 02/06/2014

Posts: 7

Like olli9000 said, this isn

Like olli9000 said, this isn't working in version 4. I need this to create a mathquill plugin, but I have to add the mathquill js to the head. I was able to do this, but the script doesn't seem to get notieced, as using mathquill() will not work. It's undefined.

Fri, 07/04/2014 - 16:55

#13

datalink

Joined: 18/10/2007

Posts: 149

Hi DieterAtWork,

the last version is:

var head = CKEDITOR.instances.metas.document.getHead();
var myscript = CKEDITOR.document.createElement( 'script', {
    attributes : {
        type : 'text/javascript',
        'data-cke-saved-src' : 'path/myscript.js'
    }
});
head.append( myscript );

This works in CKEditor 4. But I think you are looking for something like:

CKEDITOR.scriptLoader.load( this.path + 'dialogs/yourscript.js' );

Fri, 07/04/2014 - 17:08

(Reply to #13) #14

DieterAtWork

Joined: 02/06/2014

Posts: 7

It works in the sense that's

It works in the sense that's added to the head, but it's not working for what I need. Maybe I don't get it.

The situation is that the widget plugin will render mathquill, and for that, mathquill() must be called on the element, so I need to call it in the init function of the widget, as there I know the element already exists. But mathquill() is undefined, even thouhg it's added in the head.

Using scriptLoader returns true, so it seems to be successful, but it also doesn't get it to work. I call this in the init function of the plugin, but how should I use it if this is the solution?

Thx for the help.

Fri, 07/04/2014 - 18:49

#15

datalink

Joined: 18/10/2007

Posts: 149

Sorry, I think I can't help

Sorry, I think I can't help you. I use scriptLoader in some of my plugins to load external JS files and I can call every function in it from my plugins. So there will be another issue in your plugin. But I can remember it is not easy to write a plugin. I had spent weeks for it.

Tue, 07/08/2014 - 09:10

#16

DieterAtWork

Joined: 02/06/2014

Posts: 7

I did work after all, there

I did work after all, there was something else I was doing wrong. Mathquill adds it's methods to jQuery objects, and it's there I got confused. But in the end, I didn't used any method to add scripts, as it seems that loading the script in the page itself was doing the trick, as the dialog isn't in the editor, but on the page. Thx for the help.