access to selection from external plugin - feature request?

rel="lightbox" or 
rel="lightbox1" or
rel="lightbox2" aso

onOk : function ()
{
   if ( this.getValue() != '' ) { // this is my text field for rel attribute
      linkElement = this.getDialog().linkElement;
      linkElement.setAttribute( 'rel', this.getValue() );
   }
}

http://cksource.com/forums/viewtopic.php?f=11&t=22856 http://cksource.com/forums/viewtopic.php?f=11&t=22833

Mon, 07/04/2011 - 10:18

alfonsoml

Joined: 31/12/2006

Posts: 3735

Re: access to selection from external plugin - feature reque

Usually you can use the commit and setup methods, look at how existing fields work in the dialogs (ok, there are dialogs that are too complex, but in other cases the use of commit and setup it's very straight forward and allow to customize the dialogs in any way that you want)
It's specially important to note that the issue isn't the "editor selection", but also any new element that it's created in the dialog that you must adjust with your code.

Mon, 07/04/2011 - 22:20

datalink

Joined: 18/10/2007

Posts: 149

Re: access to selection from external plugin - feature reque

(function()
{
    CKEDITOR.plugins.add( 'linkonclick' );
    
    CKEDITOR.on( 'dialogDefinition', function( ev )
    {
       var dialogName = ev.data.name;
       var dialogDefinition = ev.data.definition;
       var editor = ev.editor;
       
       if ( dialogName == 'link' )
       {
            var myLink;
            var infoTab = dialogDefinition.getContents('info');
            
            infoTab.add(
            {
          type : 'text',
          id : 'onclickevent',
          label : 'onClick',
          'default' : '',
          onShow : function ()
          {
                    myLink = CKEDITOR.plugins.link.getSelectedLink( editor ) || '';
                    if(myLink != '') {
                        var clickEvt = myLink.getAttribute( 'data-cke-pa-onclick' ) || myLink.getAttribute( 'onclick' );
                        if(clickEvt != '')
                            this.setValue( clickEvt );
                        else
                            this.setValue( '' );
                    }
                },
      /*
      commit : function( data )
      {
         if ( !data.onclick )
            data.onclick = {};
         data.onclick = this.getValue();
      },
      // seems to have no effect
      */
          onOk : function ()
      {
         if ( this.getValue() != '' ) {
            //this.getDialog().commitContent( data ); // don't work
            //dialogDefinition.commitContent( data ); // don't work
            //sourceElement = this.getDialog().sourceElement; // would work if sourceElement exists in current dialog
                           //sourceElement.setAttribute( 'data-cke-pa-onclick', this.getValue() );
         }
      }
            }, 'browse');
       }
    });
})();

Mon, 07/04/2011 - 22:47

alfonsoml

Joined: 31/12/2006

Posts: 3735

Re: access to selection from external plugin - feature reque

http://alfonsoml.blogspot.com/2011/01/b ... ditor.html

      var textInput =  {
            type : 'text',
            label : editor.lang.backgrounds.label,
            id : 'background',
            setup : function( selectedElement )
            {
               this.setValue( selectedElement.getAttribute( 'background' ) );
            },
            commit : function( data, selectedElement )
            {
               var element = selectedElement || data,
                  value = this.getValue();
               if ( value )
                  element.setAttribute( 'background', value );
               else
                  element.removeAttribute( 'background' );
            }
         };

Tue, 07/05/2011 - 12:41

datalink

Joined: 18/10/2007

Posts: 149

Re: access to selection from external plugin - feature reque

Your plugin works because there is defined this.commitContent( data, table ); in table dialog. In link dialog there is only this.commitContent( data ); and I can't get access with it. However, I think there should be a simple standard methode, best with same names, for all dialogs. But thanks for the tip with setup and commit. Think I can employ it in future.