Problems with JavaScript and CKEditor

have you tried to remove the editor when the lightbox is closed?

CKEDITOR.remove(editor)

The remove function needs to be passed an object which is a little odd. Just in case there was some cleanup I used the following code:

         if (CKEDITOR.instances['editarea']) {
            CKEDITOR.remove(CKEDITOR.instances['editarea']);
         }

Kamiro wrote:The remove function needs to be passed an object which is a little odd.

Why is it odd to pass the object that you want to remove?

Thanks, appreciate the reference to the destroy function and your work.

I personally like passing in instance names instead of objects for management type classes as it's a little easier for non js folks to grasp. Just my opinion however.

CKEDITOR.remove('editarea');

or

var o=CKEDITOR.instances['editarea'];
if (o) o.destroy();

Kamiro wrote:

Why is it odd to pass the object that you want to remove?

Thanks, appreciate the reference to the destroy function and your work.

I personally like passing in instance names instead of objects for management type classes as it's a little easier for non js folks to grasp. Just my opinion however.

Hi,
Found the post very useful, also would like to share my own expierence. Firstly, CKEditor (previous FCKeditor) is great tool. Use it it many projects. Recently, faced the problem, when browser consumes to much computer memory. The project where I used FCKEditor 2.6.5 was Ajax based. So FCKeditor was loaded and unloaded for many times without refreshing the page. By saying "unloaded", I simply mean that div's with FCKEditor where set to empty (innerHtml=''). Firstly, installed Firefox addon 'Memory leak', so now I could monitor memory consumtion. I noticed that everytime I loaded FCK, memory was reserved by FF and never freed (have to mention that checked it only on Firefox 2.5.8). For instance, after reloading FCK for 30 times, FF took 63MB (2.1MB/load). It was obvious that the problem was in API. Tried to Google and the anser was to check if an instance is already initialized, and if true, clear some API variables:

   
if(editor){
   delete FCKeditorAPI.__Instances['editor'];
   delete FCKeditorAPI.Instances['editor'];
   }
var editor = new FCKeditor('editor') ;
editor.ReplaceTextarea();

But this solution didn't help my much. So I thought that maybe this problem is solved in newer FCKeditor version. Set up CKEditor 3.1. The situation was better. After 50 reloads increase in memory was 24-29MB (0.5MB/load). Well it is 4 times beter than FCK 2.6.5. It is not perfect, but is better. Besides CK loads faster. Code that I used for CK.

if (CKEDITOR.instances['editor']) {
   //CKEDITOR.remove(CKEDITOR.instances['editor']); //Does the same as line below
   delete CKEDITOR.instances[editor'];
   }
CKEDITOR.replace('editor');

If someone found better solution, please share...

That code only removes a reference to the editor, but it doesn't do anything about all the elements created by that instance or other internal code that might reference it.

Kamiro did provide a much better code using the API:

var o=CKEDITOR.instances['editarea'];
if (o) o.destroy();

I made a further research. As I mentioned the transition to CKEditor gave some benefits in memory consumption, but still it wastes memory.
Can someone check memory consumption in their Firefox (I have 3.6 with all addons disabled). The sample is already in CKEditor package (v3.2) "_samples/ajax.html". Simply load the page, load editor, check memory consumption of FF in "Windows Task Manager" and press "Remove Editor" and "Create Editor" buttons. Do this for 50 times and check how much memory FF uses. The difference will be memory leak. Destroy() is used for removal, so memory should be always released.

My statistics are:
Firefox started, page loaded, editor loaded - 46MB
After pressing "Remove Editor" and "Create Editor" for 100 memory consumption of FF is 84MB. Diff - 38 (0.38MB/load).

Checked this on Chrome, IE8 there is no memory leak...

Hm...

That will be fixed if you apply this patch: http://dev.fckeditor.net/ticket/4555 although there are still other parts of code to review.

But remember, if you don't call editor.destroy() then you won't get any benefit.

I ran into similar problems with CKEditor and JQuery. One of my webpages has a list of records. Clicking on a record opens a div to edit the record detail. I retrieve the record detail using JQuery's ajax methods and populate the div's HTML using JQuery's .html() method. The new html contains the *same* set of field names (and corresponding HTML element names) but just different record data. One of the detail fields needs to be a WYSIWIG editor, so I create a CKEditor instance for it.

This works fine when opening the first record to edit. Opening subsequent records without reloading the page generates an error. This is because CKEditor is trying to create a new instance with the same field name (and corresponding HTML element name).

The documentation is, in my opinion, misleading:

<static> {Undefined} CKEDITOR.remove(editor) Since: 3.0
Removes and editor instance from the global CKEDITOR object. his function is available for internal use mainly.
Defined in: core/ckeditor.js.
Parameters:
{CKEDITOR.editor} editor
The editor instance to be added.

Not only is it misspelled, but it doesn't clearly explain the syntax used. Worse, the statement "This function is available for internal use mainly" is vague and put me off trying to use this method for a while.

Anyway, if you can't instantiate a CKEditor and you find you need to remove an existing instance, here is the code that I used.

Warning, I tried using the destroy() method mentioned elsewhere in this thread and I got exceptions thrown within the ckeditor core code when trying in IE 8. Using the remove() method alleviated this:

if(CKEDITOR.instances.editor_name ) {
   CKEDITOR.remove(CKEDITOR.instances.editor_name);
}

The documentation is updated from last post in this topic and it says that external code should use CKEDITOR.editor.prototype.destroy to avoid memory leaks.
Example is here:
http://docs.cksource.com/ckeditor_api/s ... ml#destroy