JS error with plugin that removes the editor

Hi there,

Using this code as a plugin:

(function(){
    var b='customSave';
    CKEDITOR.plugins.add(b,{
        init:function(c){
            c.addCommand(b,a);
            c.ui.addButton('CustomSave',{
                label:'Save',  
                icon: this.path + 'icon.png',
                command:b
            });
        }
    }); 
   var a= {
        exec:function(editor){
                // ajax save content
                CKEDITOR.remove(editor);
                editor.destroy();
                editor = null;
        }
    }   
})();

Comes up with this error:
i.contentWindow is null

Any clues?

EDIT: apart from doing this:

window.onerror=function(msg, url, linenumber){
   if(msg == "i.contentWindow is null") {
      return true;
   }
}

Fri, 03/05/2010 - 18:39

alfonsoml

Joined: 31/12/2006

Posts: 3735

Re: JS error with plugin that removes the editor

Don't call CKEDITOR.remove(editor); and put the editor.destroy() in a timeout so the rest of the click handler gets properly executed.

You are trying to destroy the editor while it's handling an event, so that's too risky.

Wed, 07/07/2010 - 03:03

egenrod

Joined: 07/07/2010

Posts: 1

Re: JS error with plugin that removes the editor

I had this same problem, and found the best way to fix it was to complete the command asynchronously. However it does mean the close command does have to be called from outside the editor, which worked great for me because there were other operations I wanted to complete at the same time. Here is my code below for the plugin I created:

(function()
{
   var closeCmd = {
      modes : { wysiwyg:1, source:1 },
      exec : function( editor ) {
         editor.config.CloseFunction();
      },
      async : true
   };
   var pluginName = 'closeeditable';
   CKEDITOR.plugins.add( pluginName,
   {
      init : function( editor )
      {
         var command = editor.addCommand( pluginName, closeCmd );

         editor.ui.addButton( 'CloseEditable',
            {
               label : 'Cancel & Close',
               command : pluginName,
               icon: this.path + 'images/cancel.png'
            });
      }
   });
})();