Filtering scripts before protection

afterInit: function(editor) {
   var dataProcessor = editor.dataProcessor;
   var dataFilter = dataProcessor && dataProcessor.dataFilter;
   if (dataFilter) {
      dataFilter.addRules({
         comment: function(element) {
            alert("Found comment: " + element);
            return element;
         }
      }, 2);
   }
}

comp615 wrote:I'm confused why it is commenting them. You've removed it from the protectedSource array right? If so then it should show normally in CKEditor.

Afaik, the script tag can't be removed from the protectedSource array, but I can't find the source right now and maybe I'm recalling wrong. Anyway no, I didn't.

EDIT: oh, yeah. Found the source: looking at plugins/htmldataprocessor/plugin.js function protectSource, the script and noscript tags are automatically appended to the protection regexes. I think I filed a bugreport for this, but was marked as non important and thus unknown resolving time. /EDIT

EDIT2 comp615, do you know how to un-protect the script tag? If you do, can you please provide a working example? Thanks for your help anyway /EDIT2

comp615 wrote:I see you're using a filter priority of 2. Have you played with this number? Raising that (Try 10) might give your filter priority over whatever filter is "commenting out" the script (Beware that it might also return it as a data type other than 'comment' then). You can play around in Firebug to see what's actually coming through. Otherwise, there should be no reason that you can't use fakeObjects just like in the flash plugin.

I tested both with low (0-1-2) and high (10-100) priorities, but it doesn't seems to change. Anyway it's a min priority queue, i.e. low priorities are executed first:

         dataFilter.addRules({
            comment: function(element) {
               alert("Found comment 1:" + element);
               return element;
            }
         }, 10);
         dataFilter.addRules({
            comment: function(element) {
               alert("Found comment 2:" + element);
               return element;
            }
         }, 2);

"Found comment 2" happens always before comment 1, Q.E.D.

comp615 wrote:Bleh your right. I had it backwards from when I used it (just looked). Anyways, it's jsut a simple stack isn't it? COuldn't you in theory try poping items off the stack?

The problem is that the regexes for protecting script are inserted in the array just before protection occurs, and they are applied BEFORE any regex I may insert:

function protectSource( data, protectRegexes ) {
   var regexes =[
      ( /<script[\s\S]*?<\/script>/gi ),
      /<noscript[\s\S]*?<\/noscript>/gi
   ].concat( protectRegexes );
   // blahblah
}

data = protectSource( data, this.editor.config.protectedSource );

comp615 wrote:Alternatively, (And better in terms of figuring out if this is actually your problem) Just edit them out of the htmlprocessor then.

Yes, I thought about this solution... But I don't really like to patch the source (as this could lead to hard-to-find bugs when updating the code, as not everyone reads the documentation). This is why I preferred to work with comments (but well, it's a bad solution as it depends on the source, too, although it's not intrusive).

Anyway, this was the past: the current situation is that I've to work on scripts and insert fake objects, so protection is no longer necessary and those regexes can be placed in the configuration.

I'm trying this approach now, I'll post the results asap.

Thanks for your help
~Aki

// ( /<script[\s\S]*?<\/script>/gi ),

.myplug_script { border: 2px solid red; }

afterInit: function(editor) {
   function createFakeElement(realElement) {
      var fakeElement = editor.createFakeParserElement(realElement, 'myplug_script', 'script', true),
         fakeStyle = fakeElement.attributes.style || '';
      fakeStyle = fakeElement.attributes.style = fakeStyle + 'width:10px;';
      fakeStyle = fakeElement.attributes.style = fakeStyle + 'height:10px;';
      return fakeElement;
   }
      
   var dataProcessor = editor.dataProcessor;
   var dataFilter = dataProcessor && dataProcessor.dataFilter;
   if (dataFilter) {
      dataFilter.addRules({
         elements: {
            'script': function(element) { return createFakeElement(element); }
         }
      }, 2); // Low priority, it's not really necessary as nothing should touch the script before you
   }
}

requires: ['fakeobjects'],

duyn wrote:To akiross: where do you put the script that do the fakeElement ? is it in ckeditor/_source/plugins/yourplugins/plugin.js ?

(function (pluginName) {
   function createFakeElement(editor, realElement) {
      var fakeElement = editor.createFakeParserElement(realElement, 'myplugin_script', 'script', false);
      var fakeStyle = fakeElement.attributes.style || '';
      return fakeElement;
   }
   CKEDITOR.plugins.add(pluginName, {
      requires: ['fakeobjects'],
      init: function(editor) { /* My stuff */ },
      afterInit: function(editor) {
         var dataProcessor = editor.dataProcessor;
         var dataFilter = dataProcessor && dataProcessor.dataFilter;
         if (dataFilter) {
            dataFilter.addRules({
               elements: {
                  'script': function(element) {
                     return createFakeElement(editor, element);
                  }
               }
            }, 5);
            
         }
      }
   });
})('myplugin');