FCKeditor 2.6.4 released!

I have successfully installed FCKeditor 2.6.4 on my Drupal 6.9 development site having first read the piece by Jonathan Brinley at:
http://xplus3.net/2008/05/29/how-to-install-fckeditor-on-drupal/#comment-483

Here's a demo:
http://www.normanfellows.com/drupal/node/17

I'll edit this post if I have any further comments to make.

fredck wrote:
Several bug fixes and new features have been added, especially to our table support, including the ability of defining header rows and columns to tables. Special thanks to Alfonso Martinez and Koen Willems for their support on this.

Hi there, just found a bug in the markup generated from this fabulous editor:
--- FCKeditor generates the following-------

<table ....>
    <thead>
        <tr>
            <th scope="col">1</th>
            <th scope="col">2</th>
        </tr>
    </thead>
    <caption>My Caption</caption>
    <tbody>
        <tr>
            <td>...</td>
            <td>...</td>
        </tr>
    </tbody>
</table>

Sadly, the caption is in the wrong place!

----The following would be the correct markup-----

<table ....>
    <caption>My Caption</caption>
    <thead>
        <tr>
            <th scope="col">1</th>
            <th scope="col">2</th>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>...</td>
            <td>...</td>
        </tr>
    </tbody>
</table>

I'm going to try and fix this, but if some of the core developers could take a look at it... I guess they will manage to fix it in a few minutes

Thanks,
William Ghelfi

-----

trumbitta wrote:

fredck wrote:
Several bug fixes and new features have been added, especially to our table support, including the ability of defining header rows and columns to tables. Special thanks to Alfonso Martinez and Koen Willems for their support on this.

Hi there, just found a bug in the markup generated from this fabulous editor:
--- FCKeditor generates the following-------

<table ....>
    <thead>
        <tr>
            <th scope="col">1</th>
            <th scope="col">2</th>
        </tr>
    </thead>
    <caption>My Caption</caption>
........

.......

I'm going to try and fix this, but if some of the core developers could take a look at it... I guess they will manage to fix it in a few minutes

-----

Going further with my tests, I just found that the bug doesn't show up if you use MSIE7.
My conclusions:
- the problem is strictly related to the browser and its "DOM engine"
OR
- the problem is inside the portion of code dedicated to gecko

Waiting for some news

William

Hi !

i'm trying using tables just now... and .... oh my god ... that's not valid xhtml

so... why that caption is there? ...how can we fix it?

i just would have

<table>
<caption> .....</caption>.........
.. ... ... </table>

any ideas?

fredck wrote:@trumbitta, it looks like you have found one of those rare cases were the IE DOM is a bit smarter than FF's.

We need a ticket for it though. These forums are the wrong place for handling bugs. Please open a ticket at our dev site, including all the information you have precisely described here.

Thanks!

Thank you for the quick response
I just opened a ticket: https://dev.fckeditor.net/ticket/2874 , hoping to have done it the right way

William

zero-installation solution for spell checking

... and what about a runtime spell checking solution?

http://code.google.com/p/bjspell/

blog entry: http://webreflection.blogspot.com/2009/ ... dirty.html

Nice to see that while I created my project yesterday, you were looking for a spell checker at the end of January ... sorry if I am late

Jokes a part, I hope you'll find my project interesting. Best Regards

trumbitta wrote:

fredck wrote:@trumbitta, it looks like you have found one of those rare cases were the IE DOM is a bit smarter than FF's.

We need a ticket for it though. These forums are the wrong place for handling bugs. Please open a ticket at our dev site, including all the information you have precisely described here.

Thanks!

Thank you for the quick response
I just opened a ticket: https://dev.fckeditor.net/ticket/2874 , hoping to have done it the right way

William

For fix this problem only its necessary move at block of code in /editor/dialog/fck_table.html.

Move:

var eCaption = oEditor.FCKDomTools.GetFirstChild( table, 'CAPTION' ) ;

   if ( document.getElementById('txtCaption').value != '')
   {
      if ( !eCaption )
      {
         eCaption = oDoc.createElement( 'CAPTION' ) ;
         table.insertBefore( eCaption, table.firstChild ) ;
      }

      eCaption.innerHTML = document.getElementById('txtCaption').value ;
   }
   else if ( bExists && eCaption )
   {
      // TODO: It causes an IE internal error if using removeChild or
      // table.deleteCaption() (see #505).
      if ( oEditor.FCKBrowserInfo.IsIE )
         eCaption.innerHTML = '' ;
      else
         eCaption.parentNode.removeChild( eCaption ) ;
   }

after the line

oEditor.FCK.InsertElement( table ) ;
}

before return;


The problem is that the caption properties its define at the begining of OK function and after the code use the FCKDomTools.GetFirstChild method for put the headers and caption are replace to down position.

After some testing there were still situations in which invalid code was generated.
I just added another patch, see http://dev.fckeditor.net/ticket/2874.

Koen