CKEditor 4

Problem with test selection plugin

Mon, 12/05/2011 - 11:26
#1
chot2
chot2's picture
Joined: 05/12/2011
Posts: 26

Problem with test selection plugin

I have downloaded CKEditor 3.6.2 (revision 7275) and i have applied the following plugin http://dev.ckeditor.com/attachment/tick ... 3709.patch , when I type enough text and select a word down the page and click source , the editor is unable to scroll down to the word that i have selected in WYSIWYG mode . The following are steps i have followed .


1) Changed _source/core/config.js to
'templates,' +
'textselection,' +
'toolbar,' +

2) _source/core/dom/node.js

case CKEDITOR.NODE_TEXT :
return new CKEDITOR.dom.text( domNode );
case CKEDITOR.NODE_COMMENT :
return new CKEDITOR.dom.comment( domNode );
3) ckeditor.pack

'_source/core/dom/comment.js',

4) Added the file in follwing location
_source/plugins/textselection/plugin.js

5) Changed the following file accordingly
var currentMode = this.getMode();
this.fire( 'beforeGetModeData' );
data = currentMode.getData();
data = this.fire( 'beforeModeUnload', data );
currentMode.unload( holderElement );
data = this.fire( 'afterModeUnload', data );
this.mode = '';

6) 'core/dom/domobject' : [ 'core/dom/event' ],
'core/dom/range' : [ 'core/dom/document', 'core/dom/documentfragment', 'core/dom/element',
'core/dom/walker' ],
'core/dom/rangelist' : [ 'core/dom/range' ],
'core/dom/text' : [ 'core/dom/node', 'core/dom/domobject' ],
'core/dom/walker' : [ 'core/dom/node', 'core/dom/comment' ],


But still it isnt showing . Can anyone please let me know if I have missed anything :(

Top
Mon, 12/05/2011 - 12:01
chot2
chot2's picture
Joined: 05/12/2011
Posts: 26

Re: Problem with test selection plugin

I have tested this FF8 and IE 8 :(

Top
Mon, 12/05/2011 - 12:10
j.swiderski
j.swiderski's picture
Joined: 10/05/2011
Posts: 174

Re: Problem with test selection plugin

I have downloaded CKEditor 3.6.2 (revision 7275)

Top
Tue, 12/06/2011 - 04:58
chot2
chot2's picture
Joined: 05/12/2011
Posts: 26

Re: Problem with test selection plugin

I have applied the patch on the latest trunk and created a new build . I have opened the http://localhost/release/_samples/fullpage.html file to test . But functionality isn't working :( . Is it the right file to open ? and in the config.js file

i have removed <<<<<<< .mine

=======
plugins : 'about,basicstyles,blockquote,button,clipboard,colorbutton,contextmenu,elementspath,enterkey,entities,filebrowser,find,flash,font,format,forms,horizontalrule,htmldataprocessor,image,indent,justify,keystrokes,link,list,maximize,newpage,pagebreak,pastefromword,pastetext,popup,preview,print,removeformat,resize,save,scayt,smiley,showblocks,sourcearea,stylescombo,table,tabletools,specialchar,tab,templates,textselection,toolbar,undo,wysiwygarea,wsc',
>>>>>>> .theirs

<<<<<<< .mine

Is there anything else to be done ?

Top
Tue, 12/06/2011 - 07:31
chot2
chot2's picture
Joined: 05/12/2011
Posts: 26

Re: Problem with test selection plugin

In IE 8 when i select some text and switch to source mode I am able to see the selection but when i switch back to WYSIWYG mode i m getting stackoverflow error . Same process is making browser to crash in FF8 .

Attachments: 

AttachmentSize
Image icon ie_2.jpg201.55 KB
Top
Tue, 12/06/2011 - 11:01
alfonsoml
alfonsoml's picture
Joined: 31/12/2006
Posts: 3737

Re: Problem with test selection plugin

You are trying to use a patch created 2 years ago.
According to that ticket, no one besides Garry did test it, so we don't even know if it handled correctly your test at that moment (he mentions some issues with non-IE, but there might be other problems that he didn't found).
Besides that, lots of code have been changed in all this time, so one or several of such changes might have broke the patch.

If you want to use a patch that it's just a proposal, you should be ready to get your hands dirty, understand what the patch is trying to do, test it and if you find some problem you should start debugging it yourself because you can't expect that anyone else is suddendly gonna start debugging it for you.

Then after you have some improvements and everything works fine, you can add your new proposal so it might be added to the core and from that point it will be maintained with the rest of the code.
Top
Tue, 12/06/2011 - 11:17
chot2
chot2's picture
Joined: 05/12/2011
Posts: 26

Re: Problem with test selection plugin

Thanks for the reply alfonsoml. But j.swiderski in other form said it was working fine on the latest trunk(which even i tried ) . So , I am just waiting for his/her reply :)

Top
Wed, 12/07/2011 - 11:04
j.swiderski
j.swiderski's picture
Joined: 10/05/2011
Posts: 174

Re: Problem with test selection plugin

So , I am just waiting for his/her reply :)

Top
Thu, 12/08/2011 - 09:59
chot2
chot2's picture
Joined: 05/12/2011
Posts: 26

Re: Problem with test selection plugin

I assume that you have done everything the same way as I did and you will get this plugin working in IE9 and FF8 but not necessarily in rest of the browsers.

Yes I followed the procedure you have given but , I had an error while applying patch to particular file . Please check the image below so I added it manually .


Second. I have only said that I have checked it under FF8 and it worked there for me. I have also looked at it under IE9 where it also worked but I didn't checked it for every possible test case.[

Problem which i am facing here is , the text which I have selected in WYSIWYG mode is getting scrolled but it is not getting highlighted . And when get back to the previous mode FF8 is getting crashed .


Can this be because of the above patch application problem ?

Attachments: 

AttachmentSize
Image icon error_16.jpg201.54 KB
Top
Fri, 12/09/2011 - 09:34
chot2
chot2's picture
Joined: 05/12/2011
Posts: 26

Re: Problem with test selection plugin

@j.swiderski

Can you me help me out here . Did you get that error while applying patch ?
Top
Sat, 12/10/2011 - 16:54
chot2
chot2's picture
Joined: 05/12/2011
Posts: 26

Re: Problem with test selection plugin

@ j.swiderski

Can you please let me know what have you done for this ? Have faced this error while apply the patch ? :( Trunk was referring to a directory which was't present so I have manually added the file plugin.js

Top
Mon, 01/02/2012 - 16:42
j.swiderski
j.swiderski's picture
Joined: 10/05/2011
Posts: 174

Re: Problem with test selection plugin

Sorry for missing the post in the first place.

No I'm not getting the same error. What you are getting is related to Tortoise SVN and not patch for CKEditor.

About the plugin, sorry for giving you false hopes but it simply does not work:
1. In Webkit selection stays when switching to source but the editor does not scroll down to it.
2. In FF and IE9-7 it keeps selection and scrolls to it
3. In Opera it scrolls to the text but it does not select it
4. In IE6 it does not work.
What is more when you switch from Source to WYSIWYG mode you get stackOverflow error.

The code is 3 years old and through that amount of time many things has changed. The code for this plugin should be rewritten. It can also be treated as a jump start to writing own plugin but nothing more.
Top
Sat, 12/22/2012 - 13:56
prontsevich
prontsevich's picture
Joined: 07/09/2011
Posts: 2

Textselection plugin for CKEditor 4.x

Hi everybody!

I've just ported patch #3709 to CKEditor 4.x. Maybe it's not the best solution, but it works.

Follow these steps:

  1. Download CKEditor source files;
  2. Open ckeditor/config.js and add 'textselection' to the end of config.plugins value (like this config.plugins = 'about,menu, ... ,undo,textselection');
  3. Create folder with name 'textselection' in plugins folder.
  4. Add plugin.js from attach in the folder you created in step 3.
  5. Open ckeditor/core/creators/themedui.js, search 'setMode' function (something like CKEDITOR.editor.prototype.setMode = function(){...} ) and replace this code 
    editor.fire( 'beforeModeUnload' );
editor.editable( 0 );
editor.mode = '';

    with

    editor.fire('beforeModeUnload');
editor.fire('beforeGetModeData');
var data = editor.getData();
data = editor.fire('beforeModeUnload', data);
data = editor.fire('afterModeUnload', data);
editor.editable( 0 );
editor._.data = data;
editor.mode = '';

That's all. You should build CKEditor now to get the minified version.

It works in:

  1. IE7-9 it keeps selection (if you selected something) or cursor and scrolls to it;
  2. Chrome it keeps selection (if you selected something) or cursor and scrolls to it;
  3. FF it keeps selection (if you selected something) or cursor and scrolls to it;
  4. Opera it keeps selection (if you selected something) or cursor and scrolls to it.

Attachments: 

AttachmentSize
Plain text icon Rename it to plugin.js before using11.24 KB
Top
Tue, 03/12/2013 - 15:46
(Reply to #13)
sirtet
sirtet's picture
Joined: 16/01/2013
Posts: 31

Great, prontsevich. works for me!

Thanks for this one!

unfortunately, in the current version 4.01 ckeditor/core/creators/themedui.js looks a bit different, so i got 4.0 from github.
With this i got your plugin to work.

Results on Ubuntu 12.04:

  • In chromium 23 the scroll worked only when switching to source, not on going back.
  • In FF 18 all worked as expected.

I don't have skills to work on this, but if someone could turn this into an official plugin, that works without modifying the library, it would be a great addition to CKEditor.

Top
Sun, 11/17/2013 - 14:37
(Reply to #14)
sirtet
sirtet's picture
Joined: 16/01/2013
Posts: 31

I did an online Demo

To be able to get an online demo of the plugin (and to file a pull-request for the required change), i forked ckeditor on github (between 4.3 and 4.3Beta), added the stuff above as a plugin, and set up a jsfiddle, which uses this fork's code.

textselection online demo:
http://jsfiddle.net/sirtet/TX5bc/

Top
Fri, 11/29/2013 - 15:45
sirtet
sirtet's picture
Joined: 16/01/2013
Posts: 31

fully working plugin available!

w8tcha has improved the plugin so it needs no core patching...

https://github.com/w8tcha/CKEditor-TextSelection-Plugin/

Top
Twitter Facebook Facebook Instagram Medium Linkedin GitHub Arrow down Phone Menu Close icon Check