ACF Not Filtering When Saved

I am in automatic mode for ACF and running version 4.2.1.

In both Source view and Design view, if I paste a tag that is not allowed by ACF, the bad tag is allowed and saved. But, when the editor reloads the content, the tag is then stripped out.

My test included:

pasting an iframe tag in Source
pasting an img tag in design (with the image icon disabled)

In both of these cases the tag was stripped out after I reloaded the content.

So, is the behavior correct that ACF does not strip out pasted tags when saved?

Wed, 09/11/2013 - 13:30

sebstefanov

Joined: 03/02/2012

Posts: 1329

Well that's a first: somebody

Well that's a first: somebody wondering why CKEditor isn't stripping code... It should strip the code before saving (or just switching between source and WYSIWYG mode). Disabling the image plugin automatically strips out img tags. Would be nice to have the actual code not getting stripped. Also do you have any special setup?

Customer and Community Manager, CKSource
Follow us on: Facebook, Twitter, LinkedIn

If you think you found a bug in CKEditor, read this!

Wed, 09/11/2013 - 18:46

(Reply to #2) #3

druidfog

Joined: 07/01/2009

Posts: 12

Example Code

lol. Probably true.

Here's a link with 2 examples that shows the ACF is not stripping out tags before saving. If you view the page code, I can't get any more vanilla than that.

http://tinyurl.com/nn5sute

Fri, 09/20/2013 - 19:18

druidfog

Joined: 07/01/2009

Posts: 12

Followup

Is the ACF behaving as it should?

Fri, 09/20/2013 - 23:13

reinmar

Joined: 24/08/2012

Posts: 631

This is an interesting case.

This is an interesting case. Firstly, because as Sebastian wrote - you're the first person complaining on ACF not stripping something :D, secondly, because no one has yet reported this issue. And I think that it can be considered as a valid one.

The thing is that ACF filters data only on input. For performance reasons only ACF's transformations (this means for example <b> to <strong> transformations) are applied to output. And when you're in source mode and gets the data from editor data bypasses the input filters which would be applied when switching from source mode to WYSIWYG mode.

I reported a ticket: http://dev.ckeditor.com/ticket/10902.

Thanks.

Piotrek (Reinmar) Koszuliński
CKEditor JavaScript Developer
--
CKSource - http://cksource.com
--
Follow CKEditor on: Twitter | Facebook | Google+