http://dev.ckeditor.com/attachment/tick ... 3709.patch
'textselection,' +
case CKEDITOR.NODE_COMMENT :
return new CKEDITOR.dom.comment( domNode );
'_source/core/dom/comment.js',
var currentMode = this.getMode();
this.fire( 'beforeGetModeData' );
data = currentMode.getData();
data = this.fire( 'beforeModeUnload', data );
currentMode.unload( holderElement );
data = this.fire( 'afterModeUnload', data );
this.mode = '';
'core/dom/walker' : [ 'core/dom/node', 'core/dom/comment' ],
'textselection,' +
case CKEDITOR.NODE_COMMENT :
return new CKEDITOR.dom.comment( domNode );
'_source/core/dom/comment.js',
var currentMode = this.getMode();
this.fire( 'beforeGetModeData' );
data = currentMode.getData();
data = this.fire( 'beforeModeUnload', data );
currentMode.unload( holderElement );
data = this.fire( 'afterModeUnload', data );
this.mode = '';
'core/dom/walker' : [ 'core/dom/node', 'core/dom/comment' ],

Re: Problem with test selection plugin
Re: Problem with test selection plugin
Get SVN and download repository:
http://tortoisesvn.net/about.htmlhttp://tortoisesvn.tigris.org/
http://svn.ckeditor.com/CKEditor/trunk
Applay patch:
Build new release
http://docs.cksource.com/CKEditor_3.x/D ... CKReleaser
Re: Problem with test selection plugin
<<<<<<< .mine
=======
plugins : 'about,basicstyles,blockquote,button,clipboard,colorbutton,contextmenu,elementspath,enterkey,entities,filebrowser,find,flash,font,format,forms,horizontalrule,htmldataprocessor,image,indent,justify,keystrokes,link,list,maximize,newpage,pagebreak,pastefromword,pastetext,popup,preview,print,removeformat,resize,save,scayt,smiley,showblocks,sourcearea,stylescombo,table,tabletools,specialchar,tab,templates,textselection,toolbar,undo,wysiwygarea,wsc',
>>>>>>> .theirs
<<<<<<< .mine
Re: Problem with test selection plugin
Attachments:
Re: Problem with test selection plugin
According to that ticket, no one besides Garry did test it, so we don't even know if it handled correctly your test at that moment (he mentions some issues with non-IE, but there might be other problems that he didn't found).
Besides that, lots of code have been changed in all this time, so one or several of such changes might have broke the patch.
If you want to use a patch that it's just a proposal, you should be ready to get your hands dirty, understand what the patch is trying to do, test it and if you find some problem you should start debugging it yourself because you can't expect that anyone else is suddendly gonna start debugging it for you.
Then after you have some improvements and everything works fine, you can add your new proposal so it might be added to the core and from that point it will be maintained with the rest of the code.
Re: Problem with test selection plugin
Re: Problem with test selection plugin
I didn't checked it for every possible test case.
Re: Problem with test selection plugin
Yes I followed the procedure you have given but , I had an error while applying patch to particular file . Please check the image below
Second. I have only said that I have checked it under FF8 and it worked there for me. I have also looked at it under IE9 where it also worked but I didn't checked it for every possible test case.[
Problem which i am facing here is , the text which I have selected in WYSIWYG mode is getting scrolled but it is not getting highlighted . And when get back to the previous mode FF8 is getting crashed .
Can this be because of the above patch application problem ?
Attachments:
Re: Problem with test selection plugin
Can you me help me out here . Did you get that error while applying patch ?
Re: Problem with test selection plugin
Re: Problem with test selection plugin
No I'm not getting the same error. What you are getting is related to Tortoise SVN and not patch for CKEditor.
About the plugin, sorry for giving you false hopes but it simply does not work:
1. In Webkit selection stays when switching to source but the editor does not scroll down to it.
2. In FF and IE9-7 it keeps selection and scrolls to it
3. In Opera it scrolls to the text but it does not select it
4. In IE6 it does not work.
What is more when you switch from Source to WYSIWYG mode you get stackOverflow error.
The code is 3 years old and through that amount of time many things has changed. The code for this plugin should be rewritten. It can also be treated as a jump start to writing own plugin but nothing more.
Textselection plugin for CKEditor 4.x
Hi everybody!
I've just ported patch #3709 to CKEditor 4.x. Maybe it's not the best solution, but it works.
Follow these steps:
with
editor.fire('beforeModeUnload'); editor.fire('beforeGetModeData'); var data = editor.getData(); data = editor.fire('beforeModeUnload', data); data = editor.fire('afterModeUnload', data); editor.editable( 0 ); editor._.data = data; editor.mode = '';That's all. You should build CKEditor now to get the minified version.
It works in:
Attachments:
Great, prontsevich. works for me!
Thanks for this one!
unfortunately, in the current version 4.01 ckeditor/core/creators/themedui.js looks a bit different, so i got 4.0 from github.
With this i got your plugin to work.
Results on Ubuntu 12.04:
I don't have skills to work on this, but if someone could turn this into an official plugin, that works without modifying the library, it would be a great addition to CKEditor.
I did an online Demo
To be able to get an online demo of the plugin (and to file a pull-request for the required change), i forked ckeditor on github (between 4.3 and 4.3Beta), added the stuff above as a plugin, and set up a jsfiddle, which uses this fork's code.
textselection online demo:
http://jsfiddle.net/sirtet/TX5bc/
fully working plugin available!
w8tcha has improved the plugin so it needs no core patching...
https://github.com/w8tcha/CKEditor-TextSelection-Plugin/