TESTERS CALLED: FCKeditor 2.2

One more thing, the PlaceHolders plugin could be updated like it's described here so it can show how to use several processor for any tag:

https://sourceforge.net/forum/forum.php ... _id=379487

Thanks for the new version, lots of new code and lots of fixes.

I'm a little "blushed" for the special note that you have made in the release notes, thank you.

Now I'm looking at the changes and there are somethings that I did have changed here, mostly non-important:

In fckstyeldef_ie.js, line 77, that can be rewritten as a single call to FCKTools.RemoveOuterTags( oChild ) ;
like in gecko

I've created a patch to provide an event onKeyDown as it might not be interesting for everybody to be included in the default code, or there is some drawback in the way that I've implemented it:
https://sourceforge.net/tracker/index.p ... tid=543655

In fckdebug.js I did have some problems opening the debugger window from a plugin, the fix is to add the fckeditor BasePath:
this.DebugWindow = window.open( FCKConfig.BasePath + 'fckdebug.html', 'FCKeditorDebug', 'menubar=no,scrollbars=no,resizable=yes,location=no,toolbar=no,width=600,height=500', true ) ;


in fckselection_ie.js, line 32 the code can be rewritten a little:

var oRange = FCK.EditorDocument.selection.createRange() ;
if ( oRange && oRange.item )
return FCK.EditorDocument.selection.createRange().item(0) ;

-->
var oRange = FCK.EditorDocument.selection.createRange() ;
if ( oRange && oRange.item )
return oRange.item(0) ;


in fcktablehandler.js as madtom1999 pointed here there's a little typo at line 166:
https://sourceforge.net/forum/forum.php ... _id=257180

You have left an FCKDebug.OutputObject( el ) ;
in fcktools.js, GetElementPosition, line 167

That's all for the moment, I don't know for sure when I'll be able to test all the changes but this looks great.

Thanks.

i have the following error in the js debugger of Fifrefox
(Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1)

Erreur : uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMLocation.host]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: http://www.fckeditor.net/_temp/FCKedito ... startup.js :: <TOP_LEVEL> :: line 22" data: no]

Great work Frederico.

Lots of nice bug fixes.

You are one persistent developer... no wonder this project got the "Project of the month".

One thing with DIV in firefox.

If you insert a DIV in the editor and there is no text following the DIV... then how do you manage to put/place the cursor below the DIV and continue typing there.

That is not a problem in IE.

Now some IE stuff:

Another thing (probably not a bug, but anyway):
If you insert a DIV in IE and have specified width:50%; height:auto;

If you now mark the DIV (edit mode) and drag it's right side to make it wider... then (editor) change the height to a fixed height in pixel.
(the width are changed and unit in % are kept as it was before resizing... good)

I would really appreciate if the height:auto where used then that should not be changed at all.

If inserting a table and set width:50% and no height... and then select the table and drag to make it wider... then editor change the width unit to pixel and also set a fixed height in pixel.

Would appreciate that the unit (e.g. %) was preserved if resizing the table by dragging... and also not to set a fixed height, if that was not set.

One last thing:
I looked into the core code some while ago regarding the code that was amended when ENTER or BACKSPACE in gecko,
amended in 2.1.1:

Ref. the release on ver 2.1.1:

In the /editor/_source/internals/fck_1_gecko.js file I found a wrong reference to a variable in FCKeditor:

One place it says:

FCKConfig.UserBROnCarriageReturn

I belive it should be:

FCKConfig.UseBROnCarriageReturn

Could this be related to the bugs that where reported when the code was implemented in the 2.1 version?...
and that laiter was commented out.

Keep up the good work.

I used Firefox 1.5 on win xp sp2.
You can see a screenshot here. The caption of the button should say "Vinden", but instead I see only "V".
http://www.student.vu.nl/~rbn200/firfox-1.5.gif

This problem is still present and the same fix seems to work fine.
https://sourceforge.net/forum/forum.php ... _id=257180

I tested the <pre> bug referenced as https://sourceforge.net/tracker/?func=d ... p_id=75348

In Firefox 1.07 on OSX and Windows the behaviour is as before - it incorrectly replaces \n inside a <pre> with <br/>

In IE on Windows the behaviour is as before - it correctly leaves any \n inside a <pre> untouched.

So I can't see any difference in behaviour from before. Am I being dumb?